rlm_perl minor bug

Alexei Chetroi radius at lexa.uniflux-line.net
Thu Aug 25 10:51:27 CEST 2005


  Hi,

  It seems to me there's a minor bug in "POOL_HANDLE *pool_pop()"
function of rlm_perl module. Around line #429 perl_pool.current_clones
gets incremented, which is incorect, since it already has been incremented by
pool_grow() function.

  The rlm_perl.c file is:
  $Id: rlm_perl.c,v 1.13 2004/02/26 19:04:34 aland Exp $

See attached file for proposed fix.

-- 
  Best wishes

Smile... Tomorrow will be worse. (c) Murphy's Law
-------------- next part --------------
--- rlm_perl.c.orig	2005-08-25 11:45:09.926649520 +0300
+++ rlm_perl.c	2005-08-25 11:50:11.300997250 +0300
@@ -426,7 +426,6 @@
 		if (perl_pool.current_clones < perl_pool.max_clones ) {
 
 			found = pool_grow();
-			perl_pool.current_clones++;
 
 			if (found == NULL) {
 				radlog(L_ERR,"Cannot grow pool returning");


More information about the Freeradius-Devel mailing list