Patch to allow FreeRADIUS server 2.1.8 to compile on non-GCC systems

Scott Neugroschl redfloyd at gmail.com
Wed Apr 21 19:05:31 CEST 2010


I will fix, and resubmit.


> From: Jeffrey Hutzelman
> --On Wednesday, April 21, 2010 08:48:25 AM +0200 Alan DeKok
> >   Get rid of the /* SAN */ text everywhere.  It's useless and
> annoying.
> >  If you want to track local changes, use 'git'.
[[SAN]] 
Fine.  I don't have git on my system.  It's an oddball system --
HP Nonstop.  So the SAN was for my purposes, so I could keep track of
the changes.  Yeah, I should have killed them before submitting.
Sue me.

> 
> Also get rid of the practice of included a commented-out copy of what
> every
> line you changed looked like before the change.  That's also
> unnecessary
> and makes the patch much harder to read.
> 
Agreed.  As I said immediately above, it was for my own purposes
(the system has no version control system available)

> >   If your C compiler can't handle variable declarations, it's *very*
> old
> > and out of date.
> 
> I doubt anyone has a compiler left that can't handle variable
> declarations
> (did C _ever_ permit that?) or even initialization.  However, the
> compiler
> is within its rights to complain about a declaration which occurs not
> at
> the beginning of a block.

[[SAN]] That's the fix... the variable was not declared at the beginning of
the block.





More information about the Freeradius-Devel mailing list