Patch to fix PPTP CHAP failure due to unknown-attribute problem

freeradius developer/user identity freeradius at cecst.com
Thu Jul 7 06:43:52 CEST 2011


Alan DeKok at Wed Jul 6 17:21:38 CEST 2011 wrote:
> > Sounds like a maintainer is needed under the auspices of the freeradius 
> > project: (from http://wiki.freeradius.org/Radiusclient)
> >  Yes...  Please help. :)
> > If a maintainer is needed, I am willing to volunteer at least for now. 
>  Great.  I'll send you a whack of patches.
> > .... Would it make sense to 
> > include radiusclient in the freeradius server source tree?
>  No.  That code is *terrible*.
> > ...
>  .... I've pushed the code to github

<whine> I unsubscribed to the freeradius-user mailing list and since 
then nothing from the developer mailing list has arrived either. I just 
resubscribed to freeradius-devel and got email stating that it was a 
duplicate enrollment. So I'm copying the above from the archive at 
freeradius.org</whine>

OK, I'll take on maintenance of radiusclient, although I don't know much
about it except what I fixed. Can you help me understand in what way the
code is terrible and what would need to be corrected to bring it up to
snuff?

I've forked freeradius-client on github as user "cecst". I was thinking 
that as a first step I would apply the patches I've developed so far and 
then ask you to review and commit them.  Is this the usual way things 
are done? Is there a specific coding style that you would like to 
enforce, for example with astyle?  If so, do you have a handy style 
guide?

Thanks - Larry Widman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20110706/dcaf063b/attachment.pgp>


More information about the Freeradius-Devel mailing list