fr_packet_cmp again

Alan DeKok aland at deployingradius.com
Mon May 2 11:48:07 CEST 2011


Jakob Hirsch wrote:
> I guess there could be a problem with the handling of hash collisions.

  The code was tested for that.

> How about performance of rbtree? I'm not a data structure expert, but
> AFAIR btrees are not ideal if you have to often add new nodes (rbtrees
> seem to be much better at that than ordinary btrees, though). Not that
> it matters much, the real bootleneck is probably our mysql backend.

  It shouldn't matter much.  Once you use a DB or EAP, the performance
of the RADIUS server is irrelevant.

> @Alan: The rbtree code is only in the master branch, right? Any chance
> to get this in 2.1.x?

  There was a patch for master.  I'll put something into both branches
for 2.1.11.

  Alan DeKok.



More information about the Freeradius-Devel mailing list