Commit report for master branch

[Alan DeKok]

Brian Candler wrote:
> I was thinking of something like
> 
> foo	NAS-IP-Address =~ "^192\.0\.2\."
> 
> It never occurred to me that the RHS of a condition like that might include
> xlats.  Does the files module actually allow stuff like this?? e.g.

  Sometimes... it doesn't allow it for check items.

> steve   Cleartext-Password := "testing", NAS-IP-Address =~ "%{Client-IP-Address}"
> 
> fails to start with the following error:
> 
> reading pairlist file /Users/brian/Build/freeradius-master/etc/raddb/users
> /Users/brian/Build/freeradius-master/etc/raddb/users[76]: Parse error (check) for entry steve: dict_init: /Users/brian/Build/freeradius-master/etc/raddb/dictionary[65]: Couldn't open dictionary "/Users/brian/Build/freeradius-master/etc/raddb/dictionary.local": No such file or directory
> Errors reading /Users/brian/Build/freeradius-master/etc/raddb/users

  Weird.

> so it shouldn't matter that the file doesn't exist. When if I comment out
> this $INCLUDE- line, I get "unknown error" instead:
> 
> reading pairlist file /Users/brian/Build/freeradius-master/etc/raddb/users
> /Users/brian/Build/freeradius-master/etc/raddb/users[76]: Parse error (check) for entry steve: (unknown error)
> Errors reading /Users/brian/Build/freeradius-master/etc/raddb/users

  It looks like something else is going wrong.  Maybe a DNS issue?

> But it works if I change the condition to a fixed string literal:
> 
> steve   Cleartext-Password := "testing", NAS-IP-Address =~ "^192\."

  Yeah... it looks like the expansion on the RHS doesn't work.

> Odd. I have to say I can't really see a need for expansions in check items,
> and if they don't work today, maybe it's still reasonable to say that regexp
> values could be precompiled.

  Yes.

  Alan DeKok.