rlm_sql: zero session length

Arran Cudbard-Bell a.cudbardb at freeradius.org
Mon Jun 17 14:56:20 CEST 2013


On 17 Jun 2013, at 13:49, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:

> 
>> Why is this if statement there anyway, some buggy NASes?
> 
> Almost certainly.
> 
>> If so, why not just let user handle it in unlang?
> 
> The rlm_sql module was written before unlang, so that's why the code is there.
> 
>> IMHO that needs to be removed, or if written for a good reason, made configurable. With rfc-compliant default:)
> 
> 
> I'll remove it. It's easy enough to do the check in unlang.

It's already gone in 3.0, and you can disable it if you build from source in 2.x.x.

https://github.com/FreeRADIUS/freeradius-server/blob/v2.x.x/src/modules/rlm_sql/rlm_sql.c#L1365

It should probably be left as is for 2.2.1 for users which rely on this behaviour.

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team



More information about the Freeradius-Devel mailing list