Commit report for v3.0.x branch

The git bot announce at freeradius.org
Fri Apr 11 00:00:01 CEST 2014


New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
Lock from the start of the file.

Alan T. DeKok at 2014-04-10T20:14:29Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e6e78794209f738e66d714fe2755446ec91df271
====== 
Check lock for error

Alan T. DeKok at 2014-04-10T20:04:05Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/ebfafe72f5dfe2597431c1e1b4af83814f24628d
====== 
Use the new logfile API

Alan T. DeKok at 2014-04-10T20:01:49Z
Files modified:
	* src/modules/rlm_detail/rlm_detail.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d9b39f43f620aede773d41a930353926b52e3e68
====== 
re-open the file if someone has deleted it

i.e. while we waited for the lock, or while we were doing
something else.

Alan T. DeKok at 2014-04-10T20:00:05Z
Files modified:
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/8f78deeb8e44fae4ae9fb3161f8847556bd10217
====== 
Use mode_t, and create any necessary directories

Alan T. DeKok at 2014-04-10T19:45:16Z
Files modified:
	* src/include/log.h
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7fe23f19982d803ab3cbe9cb80e9234c34a92f49
====== 
Use the new logfile API

Alan T. DeKok at 2014-04-10T18:17:17Z
Files modified:
	* src/modules/rlm_sql/rlm_sql.c
	* src/modules/rlm_sql/rlm_sql.h
	* src/modules/rlm_sql/sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/7d1aec9661fa8dbdee6d1ce7306bdd26559a8864
====== 
Use the new logfile API

Alan T. DeKok at 2014-04-10T18:17:06Z
Files modified:
	* src/modules/rlm_linelog/rlm_linelog.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/b2ed92ccd6c8b6e33cb05edcd5f545d78ac85783
====== 
Added logging API

So that multiple threads can log to files with (a) no thread
race conditions, and (b) file locks for external processes.

We do this by opening a file descriptor for each file, and leaving
it open for a long time.  When a thread needs to log to a file,
it passes the filename to the API, and gets an FD in return.
That FD is then left open, for re-use by other threads.

The FD is also protected by a mutex, so that other threads which
try to log to the same file have to wait until the current one
is finished.

This nonsense is required because the POSIX file lock API is
per process, so that locks in one thread don't block other threads.
The POSIX API also releases *all* locks on a file when ANY FD for
that file.  So the threads can't rely on just file locks to prevent
readers from reading the wrong thing.  They have to have ONE FD
for all threads.

Since the FD is never closed, the locks on it always apply.
Since the FD is protected by a mutex, only one thread at a time
can write to the file.

And peace reigns in the land.

Alan T. DeKok at 2014-04-10T18:07:27Z
Files modified:
	* src/include/log.h
	* src/main/log.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c6b7b0ae65765128a78985d34150c6e4c5b83b96
====== 
Log files are 0640, not 0666.  WTF?

Alan T. DeKok at 2014-04-10T15:24:18Z
Files modified:
	* src/modules/rlm_sql/sql.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/24b95c38c101aea1f35335ee590984279598cce1
====== 
Allow unset auth_type to mean local

Alan T. DeKok at 2014-04-10T15:15:37Z
Files modified:
	* src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4c995fda770f31a53851d5106cbd5eb2720d51db
====== 
Free cast before checking for error

Arran Cudbard-Bell at 2014-04-10T09:11:00Z
Files modified:
	* src/modules/rlm_unpack/rlm_unpack.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/dc0f29aa4eaf5e8ff5ab703a83bd43cbd4e634b1
====== 
Check for truncation in more places

Arran Cudbard-Bell at 2014-04-10T09:09:35Z
Files modified:
	* src/main/xlat.c
	* src/modules/rlm_cache/rlm_cache.c
	* src/modules/rlm_unpack/rlm_unpack.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/3052c4d090c351ce7bda93f9728b31d7b31a2a8f
====== 
Really not a typo

Arran Cudbard-Bell at 2014-04-10T08:35:53Z
Files modified:
	* src/lib/print.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/31ad62da8d86514c845566de58c3f4cd03dea4be
====== 
Quotations around strings look nicer

Alan T. DeKok at 2014-04-10T04:19:57Z
Files modified:
	* src/main/valuepair.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/e1189107bda5f64e5b14cb4330b7713c69a74d59
====== 
Handle embedded NULs in strings for xlat.  Fixes #571

Alan T. DeKok at 2014-04-10T04:18:56Z
Files modified:
	* src/lib/print.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/a16c45ab436cc7539af388d04e2abbc7d198f6f5
====== 
-- 
This commit summary was generated @2014-04-11T00:00:01Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).


More information about the Freeradius-Devel mailing list