Version consistency checks (v3.0.x and master)

Alan DeKok aland at deployingradius.com
Thu Jan 23 19:14:21 CET 2014


Arran Cudbard-Bell wrote:
> Probably easiest just to add a VERSION keyword and check it's value
> against RADIUS_VERSION any time it's found in a dictionary.
> 
> Just adding VERSION to share/dictionary will solve most versioning
> issues.

  Ugh.  I'm not completely opposed to that solution, but it looks ugly
to me.

  The dict.c code shouldn't care much about the dictionaries, so long as
they parse correctly.  It's about separation of responsibilities.

  If there's a parse error, well... it's always because someone screwed
up the dictionary versions.  Adding a more descriptive error won't help
much here.  The people who screw that up are likely to be the same
people who don't read error messages.

  Alan DeKok.


More information about the Freeradius-Devel mailing list