[v4.0.x] fr_pair_list_afrom_file is broken (dhcpclient, radclient)

Chaigneau, Nicolas nicolas.chaigneau at capgemini.com
Tue Jun 5 17:40:43 CEST 2018


I think the following code is wrong:

https://github.com/FreeRADIUS/freeradius-server/blob/v4.0.x/src/lib/util/pair.c#L1689

		do {
			fr_cursor_append(&cursor, vp);
		} while (vp->next && (vp = vp->next));


>From what I understand, fr_cursor_append allows to add a single item at the end of the list.
But here, vp can be a list of vps (multiple vps can be passed in on a single line).

So what happens is we only get the first value pair of the line.


I tried to write all vps each on a separate line. In this case, it works.



Regards,
Nicolas.
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.



More information about the Freeradius-Devel mailing list