[v4.0.x] fr_pair_list_afrom_file is broken (dhcpclient, radclient)

[Alan DeKok]

On Jun 5, 2018, at 11:40 AM, Chaigneau, Nicolas <nicolas.chaigneau at capgemini.com> wrote:
> 
> 
> I think the following code is wrong:
> 
> https://github.com/FreeRADIUS/freeradius-server/blob/v4.0.x/src/lib/util/pair.c#L1689
> 
> 		do {
> 			fr_cursor_append(&cursor, vp);
> 		} while (vp->next && (vp = vp->next));
> 
> 
> From what I understand, fr_cursor_append allows to add a single item at the end of the list.
> But here, vp can be a list of vps (multiple vps can be passed in on a single line).

  Yeah, I pushed a fix.

  Alan DeKok.