Commit report for v4.0.x branch

announce at freeradius.org announce at freeradius.org
Thu Mar 22 01:00:02 CET 2018


New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)

======
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJasuq5IhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPBeog/+L6BiYIzs+HRsaF1D5HQ9PDvCPyXjXXodS8djSgpS
 UFfDkwDu2ZOKjIdQ+D9dm0mrC50xTvi1AM8YpwEYjjFzZIcghat61OZUNzhuzOlF
 h7fvxF6z58C8BmYix76OkW8ftRFaYwfatK31Q9nu4CyojFKuMr8EHCchk2vciRDv
 0IobHuJiNPxnJ2GqFKWqwrSWZ4Ko8ra4nG3It7SMlXbkCgGQSzqfY3nM+rBjVRgN
 w3Z8XluBWAETxvaTFvmrzzPB9ZI+rv+kuZbjA3vdR64RgLvNWg84bw9VYhmFPbCh
 GfeyYogmtDQ50pWgczBGZcTx/eTKngfsId69ZT8rKi8rtf9KvlK+XGDPvu/cSCZr
 ue76fGuelNInKohgcjb8fRkuNdn1rvHpTv8ucdqkCL3CCD2UvWg+gifSgsZeBsgu
 kPZUcR82pVhx5J1SvaQ+H3bpuXgFM0tRVY4N8wUtHyxNbleDWMLUtzncTc7Wt0/M
 A9rR6IY9Tkt36pPiFvD1HfyeOS9wJupxqTso8xMCXk4gz/72U1StcJyAhuD6wGrW
 WPtXQkA3tlBZWw4z6afmxnVqGlyqU/iRx5wVgKSNa7kI+qTODTMV78QXOyxv0WZ1
 HOK5SnCrX26YudCH8FaZ3XTnCumKfGD+IEX9UWAzXhKiMcd+e3zEgg2ySLG4FGbr
 M3c=
 =2Gon
 -----END PGP SIGNATURE-----

When TMPL_TYPE_LIST, vpt->tmpl_da is NULL if the list is empty

Matthew Newton at 2018-03-21T23:27:07Z
Files modified:
	* src/main/tmpl.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4fde12c6576c93957eacf3a8035ac43f1193884a
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJasmp3IhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPAldA//RzG33yBm2+HUzF1z2IzrkbkIsWvQMVkhBJb8x8+Q
 +IAf+YHNAWxXNUdTsVaWf3nHA816x+1rtpK55RlzxXoWXdsKZKPrDkbm2HDgrBTo
 r0ugvIEZmFu5bxMEKL/i6ge4SwRlb+bGOKlyYFzM9vPOF+7+10p5R/zxmqS94u5+
 7N0/W297qa+KwhY33dKLlLYJe0XP8yLkNiEXS9z59jil9saK+nF5mDcPxvHtZTSQ
 A3fOJEl5PO8dE48PeTyLGlnT4VMk2pnBwArK2saHB/MqEfIyDxlfK5La/VWuOVb5
 zGrYDaoXytl3l07dvtkg805a6X5F/gUZBhGnBdb5w+QK+B1TOPR4BFji060+Ip8Z
 J+N/Vlv84KIBpQTiqHtXcwfh2D+AGGmG+sFeOhLXEmT688qdyvSlt8rAYLg9nsIW
 4E+hnvcWnmam3l2O9RVCvCx5VcNoRNo1ZutpOoO5D+QUMSGXkIz5EXyYTzZqQOyB
 psE+noA1l03rRmDK9eYxZl7u3B5iVrGDRqbkp0iCzo5BWMxfBzt2uIvc2kF5uMBT
 pdRQDeOl/qWKDRmGyFl2lgWvw5nS8T2QwkdbjHMoJR42YDs1NCW69z223jQq/zAn
 vxx8UfRrz7j77tm/RUuQPO2OT/fuZvz2u3o0y81aKwJ+luJvyOeJIBNJ/2YgqTqf
 WZk=
 =N357
 -----END PGP SIGNATURE-----

Microseconds part can be 0 to 999999 so 32bits is fine

Matthew Newton at 2018-03-21T14:21:31Z
Files modified:
	* src/main/xlat_eval.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/edb197a13526bc1cdf40a787639a53b7e2b19598
====== 
s/FR_TYPE_INT8/FR_TYPE_UINT8/g

Arran Cudbard-Bell at 2018-03-21T13:52:02Z
Files modified:
	* src/main/xlat_eval.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/61720d402fd275f45e00165ae287516428854696
====== 
Print system error on localtime_r/gtime_failure

Arran Cudbard-Bell at 2018-03-21T13:50:44Z
Files modified:
	* src/modules/rlm_date/rlm_date.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/798de4c790834f6d6444c02cf2001beb31c35287
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJaslLDIhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPBZCg/8D62K8AVp2NNMLIUWv0tFdxU994TKfH7x8ept7576
 Q9zLkmxfd0NOx5dyGEEP3ZHYHpqAcQhoWaNViYK6NlK18ypbKPql25gfY/sZRGej
 g3WkLOpGYSo0sXr4oXpYnzyVZpVsccGCzeZzpZ5XC2qmEU4SKjMolA8NUsVQXgFR
 6GzXLQxcSa0vFRv67W4IALWigSFk5yEMOpb32SM95BXiwSNb79gMIomrFwdCRf8y
 hcdu5ZSpEx/NXVCHQiNCYa8rSHqo5kro7lv65RgmR9TcoeDvW3eVLnqAZGhDRiUf
 7QkNGgICqRRrZRdJjuUWK3WqvvrNSMqlqg4fRlwB+ro+EDdNiS87x2GQkZXdCGCG
 5t01DK5VlukIIgKPFct47g1LoBtQyNDS3wPmPvjWRUVx/AM+tcZEhgnnsGoESYwF
 k3ie2IU0w/CAOmUk3b9gxQqXD2rSkLPjMcOCYZ6ZruuKLEam1QRLu3S1yN7q1aIE
 4EtXB9WCdTL/7XTcjRUFfe0vXpeqULqHteOxi3cXOnZXxImTDIqryiKDZr8ScSwT
 Kcdp1WHt117561FRyGPr0nh93LlKDcf7XIc6qoRBEBPPguZVvX+FkhmYtx9l8aJH
 OkmKNy634ZPqZge4UaGaYdGapMT0dZPz5PkOpdn4AfzZw/oXpXl3c7wVLkNP8ehw
 8B0=
 =nxLV
 -----END PGP SIGNATURE-----

Use string not array so we don't expand random junk

Matthew Newton at 2018-03-21T12:39:50Z
Files modified:
	* src/lib/util/value.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/4f410ea25e2e679b94a357e6cd77ce07d19a36b2
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJaslJ2IhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPBp2Q//VX5WepIQIvsEIDLxI/VGET8J3fl+5tApbp/9ZIx4
 3VANvXjpfgkzYaL8GYrW7gm166c/F0G0eXl3Ovgcxg1RwzNttQHyGT+f9aND8PoZ
 ORSOCudfG7WoGqdsP5eA1be6onfIjgQV/BllfApB31T3P/veGw1UqidbpzMaT/xn
 Q4AE9W7cDRkWGyoHhNJXwg/sGSBM0vTfQSO+TGM43HXUBRCn3/AfNJXrQ+qvXrAH
 ikJylh8i041ddFUnnwVL8Lt5go9+RkGBpxDB7ekzLnWU/I4r4fHseQvGVJtkFJ0O
 DfwlOv1/Nvsm08H/dOU9r5tjt+UsMflJEwDOZKzOqw9EhOqwXE82iFI1ADcPizRP
 PzKLHd+x4fSY4AWRjt3o+gRR8DVh7ycfXw3i6RUqUMnBWXug3XiQYc0bjyez9ihH
 aV88ilMPThwk0Xu4qbHSFjSm/QHlkTQaVFr8p6QRpDgVw3sQo8WU0WyFyNANgAF2
 l9/b7Hum9ZxeIcqeT/ZG46z8s3Z4RLSj3KTmA9DEcvEHAPDLn3o6bYo6UBpXY0Z9
 RUgxin8vGjLzICw78gzbiZsWGs8TYjyjjLEPdKsq6GlNTJI0/xhTF3jo8YrRRvKO
 O/9O1pzikqN9p4QTdCFJnkvAVye2X3uDkRy+WqAOvMvDo/F8R+SejY3czVOZFtO+
 0Ug=
 =0rC/
 -----END PGP SIGNATURE-----

Tidy code into a slightly neater order

Matthew Newton at 2018-03-21T12:38:59Z
Files modified:
	* src/main/xlat_eval.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/2cdc8f44a0c7d473c77f49af22c5077a0414a976
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJaslIqIhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPA9gg//XSI+M4I0wC4sfXuZtSAZK7NdSYHTbOmYsR6UuTvA
 bpKonQf4HQlMWHUAR2Gbzj9nt2I30LCCedaUGe8EdwX5to6ivdmwwBccYukN+ysx
 fDVp6g8Bvy+3ea1JIaZHU00v3ZqqlDrBCvkfGlGQ65PoMC6boMjD7ZW9awGmF7nC
 4v7L9E2OUXUciy3nYsZeiZi38XPGix20WL3hhQLWLn7AtcWn7hsB0ar7ibheoCVR
 SwXZ0w8fVOLDz2fMUrQAe1+jJdBt68yK0ruceGwlNDXreB5BCeN0HU21ttsTdZOj
 F2x+VLcRcLRllBU7nt+xmmWmGhy5Z8w3k8IF+7YNjKjReULdrru6NievipVKZLm4
 Cbll60vsuLvU/8UAeCYhwchyPktR5qwEtdNLGQV2asa2+nLmQl0YnKqLD9mlngdA
 YcOEDHIY6YNEp/dIA2NX9gqNVIpTdXTwLcX3xm8jjW8VeZwx4He+fBarFsLzJ3ME
 +OvokZf8qLm1jPKAXaefAO7yxTu9Eq3SgiCTiceJZEMRZ2dSl9j3h09TnEHWzEy3
 sGzN8jp+ujU0EKA9UOha3LpviAfQ3Ti0fMn3KGRcfyt6OLZr4VpDkG2qoV2UjaTP
 jD07FiB2JpA9cI6b6VijP0U+Y4WEVmOzJ32yTK61DDNiOhzT6WT6PdsKDsSDKz9K
 P2w=
 =5UjT
 -----END PGP SIGNATURE-----

Being consistent is nice whether numbers or strings

Matthew Newton at 2018-03-21T12:37:06Z
Files modified:
	* src/main/xlat_eval.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/c9b981cbf4cf42d85e0b6fb7632113f51a8c3e58
====== 
If values need to be zero padded they should be fed into the padding expansions

It's not ok to mess with the underlying data type just to get a particular presentation format.

The whole point of reworking the xlat code to take discreet boxed values is that upstream consumers of the output can use real types to make proper casting and comparison decisions.

By forcing these values to strings there's a high chance that they'll be fed into a lexicographic comparison function instead of the server just using integer comparisons (they would be now anyway, but we're moving towards something better).

Arran Cudbard-Bell at 2018-03-21T08:34:21Z
Files modified:
	* src/main/xlat_eval.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/d97f567ada48497e9cc73cffc669399f74e656f7
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJasaHBIhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPAGyg//UMDjdldPwMXg961Nfm8UlVYslBBqEvcZf5dYYGn2
 G2GXDtipPhNggB41gBGgkqR6HRgiE2cnMB+bc6YxQzI0Za0TmlO/BwoOMDnxJBJX
 sFYbFsTMasbZs1RNx3TF2+/ZGGJ1sLI0XbaoOfy/xz/CtJt/LNOct4656gHkeGMu
 tBlSV5GwX9PKAjvkUoW0oC/Ksu6RcCaUpqDaloENhHFpdtzSGYJzihxhNSgx/5X8
 Fth+iJkM6iFkB4nyfu2xrtFdNazq7/BQQOPPPIPK5TLzEFGQYqPTJ0Enb2wkEi/7
 S9CpRQDWYDGxFLol9LmvL7rip/4COYX3OaiolfIoQH0dyMDieCZsfzkZyr9527XN
 uj2edJ0vp1EQFPFcbL0ht4PCb+CIKh+2nGXskXgs54/FOQ904t1lMD4L/M0p1eDa
 5qx27cehEqqTwhNeEVyI2U+eSQSfcryenVaM3Jr5SOpOau+bUTMlC5VEHGGDPtHm
 9Dxe73fzqatEorcrdsxXGhfh0aF7lJ4Vhv9gkfUG/+7PcVakFzHVpRmfgHbjIP46
 Y0/Ts94Y92Vjn9LDjwSzbntO0CRPWCiJI3pTSzKBuV+XHo5hfG1wMTyiAhtBSe1c
 bQsxDbUWcWJnx1TRa8rwdy2T1xAJp4jemQ2w+5QnRgtPnv/XV9IrIuIBHAizPAnI
 Vw0=
 =ktk6
 -----END PGP SIGNATURE-----

give rlm_date ability to return request/now time in different formats

Matthew Newton at 2018-03-21T00:05:21Z
Files modified:
	* raddb/mods-available/date
	* src/modules/rlm_date/rlm_date.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/eec464acd76c688ba75300c144390c11013d7875
====== 
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQI/BAABCAApBQJasaG2IhxtYXR0aGV3LWdpdEBuZXd0b25jb21wdXRpbmcuY28u
 dWsACgkQ2bkzwSrtdPBiUg//RwLeCDRhb35bqWksMWX5oCsV26BOU+0hu5y3wLJs
 fKy7sidVMTuWoOClvRVFB4TDKhW1JaFwSiNVaSS17DUzdp7Vm320LopNk2OetD87
 Sb3Sk+Y3iL+txl45meFeRSX1ylH2toORJkKeKT0S54NCeBAp6D131X17sqwOs1wK
 LUA/dgO3wOZ+VdPFd/bwv8GdUcU3UL0qUctdScptyXBX3X3wcgTU/pfA0g7SnXFf
 3euIhT+/3Ybb5l7v5PWGY+nMv4XijFy1hHf4qFmItZ3xl/MarZN0ytAb9M0MGdBa
 +rpPq57DGhpkBoegpVfHNLklBMQvRI1/zyMqekoAqXcRVQ+GuGYJYgiwhF44Fdof
 PDX+pPKzZcVIWlCqbnOYfpAbVwWwDRJr2TdpimvPO0s59zKsG1YjwaBOQpZJvOsj
 tO9bRoSH5voNiRG/YI0kmTaQblJvxDJ6CjxuCVqzotFDrD+v7R/pFiYB4xzJtThK
 nwhVRODuWXiesZR+a7/+s0C9mHfxyRo8ZC+ZmYMc4k+vaVqfk3s/AgIvYmQhSm0R
 3ssU8NDbunDTDqJe92cAdUtzDLnoF7dXLCaQqkBNEln01oeXx8beqFfY8ikq0InW
 Xr7kbbTt/cJxNURAtkw+FggIzGrffSDZyiBWHA16bGLOKtkbGeqeRvtyUhUcT6XN
 6Ck=
 =OF+F
 -----END PGP SIGNATURE-----

rlm_date: separate logic from encoding/conversion

and get rid of all the gotos in the process

Matthew Newton at 2018-03-21T00:05:10Z
Files modified:
	* src/modules/rlm_date/rlm_date.c

Commit diff:
https://github.com/FreeRADIUS/freeradius-server/commit/fd52f38bc4511b743031c22d3daf185e13669c1a
====== 
-- 
This commit summary was generated @2018-03-22T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).


More information about the Freeradius-Devel mailing list