<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:Arial;
color:windowtext;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'>The rlm_mschap change to create the Module-Failure-Message
attribute creates it on the request chain. I notice that the original
commit on 2010-09-10 (</span></font><span lang=EN><a
href="http://github.com/alandekok/freeradius-server/commit/35ee205d4e2dcb4fe5e34143a06bd9cafd279eeb">35ee205d4e2dcb4fe5e3</a>)
</span><font size=2 face=Arial><span style='font-size:10.0pt;font-family:Arial'>had
it in the reply. Then, a subsequent commit intentionally changed it to the
request (</span></font><span lang=EN><a
href="http://github.com/alandekok/freeradius-server/commit/401dcce982f9a9972bc7bb87d5ee7e0bf3888f3a">401dcce982f9a9972bc7</a>)</span><font
size=2 face=Arial><span style='font-size:10.0pt;font-family:Arial'>. Would
you be opposed to putting it back on the reply chain? I ask because of
the pending change to save the reply attributes upon failure to survive the
final eap round trip. If it’s not in the reply chain, then it gets lost.
If you’re opposed to this, should the request chain be saved as
well (or perhaps just save Module-Failure-Message if it exists)?<o:p></o:p></span></font></p>
</div>
</body>
</html>