<br><br><div class="gmail_quote">On Sat, Mar 9, 2013 at 8:50 AM, Arran Cudbard-Bell <span dir="ltr"><<a href="mailto:a.cudbardb@freeradius.org" target="_blank">a.cudbardb@freeradius.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I've refactored the code and shrunk it.<br>
<br></blockquote><div>I really appreciate your help on this. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The code you submitted leaked opaque data, which i've fixed.<br>
<br>
I'm concerned about the call to storeUserName, and getConnection, there's no where where the connection is explicitly destroyed, so I don't see how memory passed to those functions or allocated by those functions is ever freed. I guess there must be some magic GC/reference counting i'm missing?<br>
<br>
------<br>
<br>
Regarding the library.<br>
<br></blockquote><div>I actually packaged it for fedora listed here <a href="http://koji.fedoraproject.org/koji/buildinfo?buildID=383324">http://koji.fedoraproject.org/koji/buildinfo?buildID=383324</a> .<br><br>So I use the that packaged version when building EAP-TNC module for freeradius, and somehow I did not have any of these issues while building the module. I will surely look for and try to eliminate the errors you noticed. <br>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The build scripts for tnc-fhh are poor and do not work correctly on my system (OSX 10.8.2, Apple clang version 4.0, cmake version 2.8.10.1).<br>
<br></blockquote><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I get errors from the linker/clang<br>
<br>
clang: error: invalid argument '-current_version 0.8.4' only allowed with '-dynamiclib'<br>
<br>
and when I add<br>
<br>
clang: error: invalid argument '-bundle' not allowed with '-dynamiclib'<br>
<br>
Adding -dynamiclib and removing -bundle from CMakeFiles/dummyimv.dir/link.txt fixes this, but i'm guessing there's a better way.<br>
<br>
ditto for:<br>
imcv/hostscanner/imv/CMakeFiles/hostscannerimv.dir/link.txt<br>
imcv/clamav/imv/CMakeFiles/clamavimv.dir/link.txt<br>
imcv/example/imv/CMakeFiles/exampleimv.dir/link.txt<br>
imcv/platid/imv/CMakeFiles/platidimv.dir/link.txt<br>
<br>
tncutil/CMakeLists.txt doesn't specify linker flags for libssl libcrypto or boost_system / boost_system-mt, so the linker fails with unresolved symbols.<br>
<br>
I added them manually:<br>
target_link_libraries(${PROJECT_NAME} ${Log4cxx_LIBRARY} ${XercesC_LIBRARY} ssl crypto boost_system-mt)<br>
<br>
I'm guessing there's a better way of doing this.<br>
<br>
The code itself has typos and won't compile:<br>
<br>
tnc-fhh/imcv/hostscanner/imv/src/HostScannerIMV.cpp:318:9: error: use of undeclared identifier 'u_int'<br>
u_int pos = line.find_first_of('=');<br>
<br>
Changing it to unsigned int at least allowed the build system to get past that.<br>
<br>
and there's an obvious typo here:<br>
<br>
nc-fhh/imcv/platid/imv/src/PlatidIMV.cpp:209:16: warning: equality comparison result unused [-Wunused-comparison]<br>
nothingWrong == false;<br>
<br>
That should be an assignment operator.<br>
<br>
Finally:<br>
<br>
CMake Error at imunit/cmake_install.cmake:31 (FILE):<br>
file INSTALL cannot set permissions on "/usr/local/include"<br>
<br>
Why is the install script attempting to change permissions on /usr/local/include in the first place?<br>
<br>
I'll take a look at the eap-ttls modifications later, and do them as a separate commit.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Again, your effort is very much appreciated. <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
-Arran<br>
<br>
<br>
-<br>
List info/subscribe/unsubscribe? See <a href="http://www.freeradius.org/list/devel.html" target="_blank">http://www.freeradius.org/list/devel.html</a><br>
</div></div></blockquote></div><br>