<div style="line-height:1.7;color:#000000;font-size:14px;font-family:arial">hi, all guys and administrators,<br>I have a pull request #292 about ipv6 issue on master brach<br><br>src/lib/misc.c, fr_ipaddr_cmp()<br><br><table class="file-code file-diff hide-line-numbers line-number-attrs"><tbody><tr class="file-diff-line " id="src-lib-misc-c-P2" data-position="2"><td id="L0L561" class="diff-line-num linkable-line-number" data-line-number="
561
"><br></td><td class="diff-line-code"> #ifdef HAVE_STRUCT_SOCKADDR_IN6
</td>
</tr>
<tr class="file-diff-line " id="src-lib-misc-c-P3" data-position="3">
<td class="diff-line-code">
case AF_INET6:
</td>
</tr>
<tr class="file-diff-line gd" id="src-lib-misc-c-P4" data-position="4">
<td class="diff-line-code">
- if (a->scope < b->scope) return -1;
</td>
</tr>
<tr class="file-diff-line gd" id="src-lib-misc-c-P5" data-position="5">
<td class="diff-line-code">
- if (a->scope > b->scope) return +1;
</td>
</tr>
<tr class="file-diff-line gd" id="src-lib-misc-c-P6" data-position="6">
<td class="diff-line-code">
-
</td>
</tr>
<tr class="file-diff-line " id="src-lib-misc-c-P7" data-position="7">
<td class="diff-line-code">
return memcmp(&a->ipaddr.ip6addr,
</td>
</tr>
<tr class="file-diff-line " id="src-lib-misc-c-P8" data-position="8">
<td id="L0L567" class="diff-line-num linkable-line-number" data-line-number="
567
"><br></td></tr></tbody></table><br>this fix according to my test configuration, <br>1. problem<br><br>1.1 /usr/local/etc/raddb/clients.conf, add link local client <br>client fe80::/16 {<br> secret = cameo<br> shortname = atgs950<br>}<br><br>1.2 /usr/local/etc/raddb/sites-available/default, open ipv6 auth and acct:<br>ipv6addr = :: # any. ::1 == localhost<br><br>1.3 client send auth request, server debug info as below:<br>Wed May 22 11:18:57 2013 : Error: Ignoring request to auth interface eth0 address :: port 1812 as server default from unknown client fe80::290:c0ff:fe82:1630 port 49153 proto udp<br><br>2. I realy think scope is not necessary as a rb-tree key, for ip address will be unique and represent the scope "global", "link", "site", and it's transport issue<br>3. I also found no place to parse configured address's scope id<br><br>anyone can tell me if it's code issue or not?<br><br>please help review pull request, !
thanks<br><br></div><br><br><span title="neteasefooter"><span id="netease_mail_footer"></span></span>