Proxy when module_accounting rejects the request

[Alan DeKok]

Nicolas Baradakis <nbk at sitadelle.com> wrote:
> I noticed that accounting requests are proxied anyway even if a module
> of the accounting section rejected the request. I don't know whether
> this is the expected behaviour or not. In other words: is this a bug
> or feature ? :-)

  I would say there's a few bugs there.  If "preacct" says that the
request should be proxied, we probably shouldn't even run "accounting"
at all.  That will let people log local accounting data only for
requests that are handled locally.

> Perhaps there are reasons to always proxy an accounting request, but
> I'm thinking the action might be:
> 
> Return value		Proxy	Drop
> --------------------------------------
> RLM_MODULE_REJECT		  X
> RLM_MODULE_FAIL			  X
> RLM_MODULE_OK		  X
> RLM_MODULE_HANDLED	  X
> RLM_MODULE_INVALID		  X
> RLM_MODULE_USERLOCK		  X
> RLM_MODULE_NOTFOUND		  X
> RLM_MODULE_NOOP		  X
> RLM_MODULE_UPDATED	  X

  That sounds reasonable, except for FAIL.  If we fail to log
accounting data, it's even more useful to proxy it.

  And most of those return codes don't make sense for accounting
requests.  Since accounting just does logging, the return codes should
be:

  FAIL, OK, HANDLED, INVALID, NOOP.

  REJECT doesn't make sense.  USERLOCK doesn't make sense, and I'm not
sure what UPDATED means.

  Alan DeKok.