SQLcounter patch - Addition of reply-attribute

[Jonathan De Graeve]

>   That's really what multiple module are for.  Have the sqlcounter
> module return a special return code when the user is over the limit,
> and use module failover to switch on that return code, and run another
> module.

Ok, any idea on the return code to be used?
> 
> > -       char *counter_name;     /* Daily-Session-Time */
> > -       char *check_name;       /* Max-Daily-Session */
> > -       char *key_name;         /* User-Name */
> > +       char *counter_name;     /* Daily-Session-Time */
> 
>   Why?  Gratuitous whitespace changes don't belong in a patch.

My bad, sorry

> 
> > -               if ((reply_item = pairfind(request->reply->vps,
> > PW_SESSION_TIMEOUT)) != NULL) {
> > +               /* if ((reply_item = pairfind(request->reply->vps,
> > PW_SESSION_TIMEOUT)) != NULL) { */
> 
>   If you're changing code PLEASE do not leave the old code in
> comments.  It's confusing, and pointless.  CVS will tell you what the
> old code was.  This practice is just unnecessary.

This was for internal purposes only. I'll submit the patch in the form
you want it to bugs.freeradius.org. I hope its compatible with the CVS
code.

J.