Link problem in v2.1.1

[Alan DeKok]

John Center wrote:
> I think I found a problem when compiling v2.1.1:
> 
> gmake[4]: *** No rule to make target `-lreadline', needed by `radmin'.
> Stop.

  Hmm... good point.

> In src/main/Makefile:
> 
> radmin: radmin.lo $(LIBREADLINE) $(LIBRADIUS) util.lo log.lo conffile.lo
>        $(LIBTOOL) --mode=link $(CC) $(LDFLAGS) $(LINK_MODE) -o $@ $^
> $(LIBS)
> 
> I think it should be:
> 
> radmin: radmin.lo $(LIBRADIUS) util.lo log.lo conffile.lo
>         $(LIBTOOL) --mode=link $(CC) $(LDFLAGS) $(LINK_MODE) -o $@ $^
> $(LIBS)

  Pretty much, yes.

> "-lreadline -ltermcap" are already in LIBS in Make.inc, so I don't think
> LIBREADLINE is needed here.

  I'll re-arrange the dependencies.  One of the issues with adding
-lreadline to LIBS is that ALL of the modules end up depending on
libreadline (via libtool...) which is crazy.

  Alan DeKok.