Possible memory leak in rlm_sql?

[Alan DeKok]

Brian Candler wrote:
> I noticed something in rlm_sql.c function rlm_sql_process_groups().
> 
> group_list is allocated at the top of the function, but
> sql_grouplist_free(&group_list) is only called at the end.  All the various
> error exits don't call it.
> 
> ISTM that's going to leak memory in event of errors, but perhaps I have
> overlooked something which prevents that.

  Nope.  You're right.

  Alan DeKok.