[PATCH] fix connection limits

Brian Julin BJulin at clarku.edu
Thu Jun 14 16:56:54 CEST 2012


Attached is an improved version of one of the patches originally posted here.

http://lists.freeradius.org/pipermail/freeradius-users/2012-May/060820.html

It moves decrements of socket/client num_connections counters into event_new_fd so that it
happens on all paths by which a connection may be removed.  As the code now stands,
when a connection is terminated by the other side, num_connections continues to count
it towards connection limits.

(Note that with the above code, num_connections will still count a dead connection
towards limits until it has been abandoned by all users and cleaned up.  Also I'm not completely
sure this is immune to races since I haven't yet figured out if the connection garbage collection
might be reentrant.)

This has been tested in a radsec pure-proxy relay setup.  It has not yet been tested in an AS
setup.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20120614/a6bc3b59/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_limits.diff
Type: text/x-diff
Size: 1901 bytes
Desc: fix_limits.diff
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20120614/a6bc3b59/attachment.diff>


More information about the Freeradius-Users mailing list