Return-Path: Received: from tuna.sandelman.ca [2607:f0b0:f:3::184] by obiwan.sandelman.ca with IMAP (fetchmail-6.3.21) for (single-drop); Wed, 16 Jul 2014 13:54:21 -0400 (EDT) Received: from tuna.sandelman.ca ([unix socket]) by tuna (Cyrus v2.4.16-Debian-2.4.16-4+deb7u1) with LMTPA; Tue, 15 Jul 2014 22:11:36 -0400 X-Sieve: CMU Sieve 2.4 Received: from colo4.roaringpenguin.com (colo4.roaringpenguin.com [174.142.115.36]) by tuna.sandelman.ca (Postfix) with ESMTPS id 8A37C20028 for ; Tue, 15 Jul 2014 22:11:36 -0400 (EDT) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by colo4.roaringpenguin.com (8.14.3/8.14.3/Debian-9.4) with ESMTP id s6G2AIbC014612 for ; Tue, 15 Jul 2014 22:10:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbaGPCKR (ORCPT ); Tue, 15 Jul 2014 22:10:17 -0400 Received: from tuna.sandelman.ca ([209.87.249.19]:60047 "EHLO tuna.sandelman.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbaGPCKQ (ORCPT ); Tue, 15 Jul 2014 22:10:16 -0400 X-Greylist: delayed 335 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Jul 2014 22:10:16 EDT Received: from sandelman.ca (obiwan.sandelman.ca [IPv6:2607:f0b0:f:2::247]) by tuna.sandelman.ca (Postfix) with ESMTP id 6079020028; Tue, 15 Jul 2014 22:05:49 -0400 (EDT) Received: by sandelman.ca (Postfix, from userid 179) id 6F19563B0E; Tue, 15 Jul 2014 22:04:33 -0400 (EDT) Received: from sandelman.ca (localhost [127.0.0.1]) by sandelman.ca (Postfix) with ESMTP id 50E2263AED; Tue, 15 Jul 2014 22:04:33 -0400 (EDT) From: Michael Richardson To: linux-ppp , freeradius-devel@lists.freeradius.org Subject: about that partial copy of radiusclient in pppd/plugins/radius X-Attribution: mcr X-Mailer: MH-E 8.2; nmh 1.3-dev; GNU Emacs 23.4.1 X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0;<'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m Sender: linux-ppp-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ppp@vger.kernel.org X-Bayes-Prob: 0.8948 (Score 2, tokens from: mcr, @@RPTN) X-Spam-Score: 2.00 (**) [Hold at 5.10] SPF(none:0),DKIM(none:0),Bayes(0.8948:2.0) X-CanIt-Geo: ip=209.132.180.67; country=US; region=North Carolina; city=Raleigh; latitude=35.7721; longitude=-78.6386; http://maps.google.com/maps?q=35.7721,-78.6386&z=6 X-CanItPRO-Stream: sandelman-ca:mcr (inherits from sandelman-ca:default,rp-customers:default,base:default) X-Canit-Stats-ID: 02MqOai87 - 79a3fe6af00b - 20140715 X-Antispam-Training-Forget: =?utf-8?q?https=3A//antispam=2Eroaringpenguin=2E?= =?utf-8?q?com/canit/b=2Ephp=3Fi=3D02MqOai87=26m=3D79a3fe6af00b=26t=3D201407?= =?utf-8?q?15=26c=3Df?= X-Antispam-Training-Nonspam: =?utf-8?q?https=3A//antispam=2Eroaringpenguin?= =?utf-8?q?=2Ecom/canit/b=2Ephp=3Fi=3D02MqOai87=26m=3D79a3fe6af00b=26t=3D201?= =?utf-8?q?40715=26c=3Dn?= X-Antispam-Training-Spam: =?utf-8?q?https=3A//antispam=2Eroaringpenguin=2Eco?= =?utf-8?q?m/canit/b=2Ephp=3Fi=3D02MqOai87=26m=3D79a3fe6af00b=26t=3D20140715?= =?utf-8?q?=26c=3Ds?= X-CanIt-Archive-Cluster: irqpXI7aJGyo4Ewta7qVH399FOg X-Scanned-By: CanIt (www . roaringpenguin . com) on 174.142.115.36 According to the git history on pppd, back in Nov. 14, 2004, radiusclient, which had been imported into pppd, got merged so that only the critical pieces were present. https://github.com/wkz/pppd/commit/4abe4296f0eddbb2b6ff11dbbd27100156c85f87 This was likely the right decision at the time. The Freeradius folks picked up radiusclient see: http://freeradius.org/freeradius-client/ and https://github.com/FreeRADIUS/freeradius-client I have need to add the IPv6 attributes, which means having ipv6addr and ipv6prefix values, and adding decode support for that. I'd rather not work on ancient code, yet the latest freeradius-client doesn't have the support I need anyway. It appears that there are the following differences: 1) rc_handle on all calls; not much of a problem. 2) use of pppd's error() call rather than rc_log(), I'm sure that I can work this out in the freeradius-client library with a pointer to function somewhere. 3) some other stuff involving VENDOR_NONE and the like. It appears to be simple divergence. My opinion is that freeradius-client does not need to compile to a .so, that's it's better as a straight .a, most projects never need to install it, just link it in. My other opinion is that 99% of uses of pppd client ends, or are server ends that do not use the radius plugin, and for the rest, it's not enough to have libradiusclient.a, you need a bunch of /etc/*radiusclient/.. stuff too. If I were packaging pppd for a distro, I'd make the radius part a seperate package. In git, I'd make the freeradius-client a submodule, and in tar.gz form, I'd just document that you should extract freeradius-client.tgz "HERE" Opinions? -- ] Never tell me the odds! | ipv6 mesh networks [ ] Michael Richardson, Sandelman Software Works | network architect [ ] mcr@sandelman.ca http://www.sandelman.ca/ | ruby on rails [ -- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html