Any reason why rlm_sql_unixodbc.so and rlm_sql_postgresql.so use hardcoded rpaths?
Hiya, This has been flagged to me by one of our development partners. Apparently when the rpath check is added to the RPM build command, the following errors are flagged up for the UnixODBC and PostgreSQL modules: ERROR 0001: file '/usr/lib64/freeradius/rlm_sql_unixodbc.so' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/freeradius/rlm_sql_postgresql.so' contains a standard rpath '/usr/lib64' in [/usr/lib64] I've tried the standard trick as per http://fedoraproject.org/wiki/RPath_Packaging_Draft (i.e. passing --disable-rpath) but only the 'last resort', using chrpath, works. Is there a specific reason why UnixODBC and PostgreSQL use hardcoded rpaths? Of course, Alan D, fixes are always welcome (and I'm happy to provide those once I figure out how to make them go away). :-) With Regards Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 Janet, the UK's research and education network. Janet(UK) is a trading name of Jisc Collections and Janet Limited, a not-for-profit company which is registered in England under No. 2881024 and whose Registered Office is at Lumen House, Library Avenue, Harwell Oxford, Didcot, Oxfordshire. OX11 0SG. VAT No. 614944238 Janet(UK) is a trading name of Jisc Collections and Janet Limited, a not-for-profit company which is registered in England under No. 2881024 and whose Registered Office is at Lumen House, Library Avenue, Harwell Oxford, Didcot, Oxfordshire. OX11 0SG. VAT No. 614944238
Stefan Paetow wrote:
This has been flagged to me by one of our development partners. Apparently when the rpath check is added to the RPM build command, the following errors are flagged up for the UnixODBC and PostgreSQL modules:
ERROR 0001: file '/usr/lib64/freeradius/rlm_sql_unixodbc.so' contains a standard rpath '/usr/lib64' in [/usr/lib64] ERROR 0001: file '/usr/lib64/freeradius/rlm_sql_postgresql.so' contains a standard rpath '/usr/lib64' in [/usr/lib64]
I'm not sure... I'd have to see the detailed build logs to be sure. The build system in v3 *does* pas -rpath to the linker. This is because it tries to build against a known library. If that breaks things on your system, you can edit the build system to remove -rpath. :( Alan DeKok.
The build system in v3 *does* pas -rpath to the linker. This is because it tries to build against a known library. If that breaks things on your system, you can edit the build system to remove -rpath. :(
Ahh, so -rpath in this case is intentional. I'll mention that to our partners :-) It's just odd that only those two modules have a hard-coded rpath, the rest are fine (and pass the check-rpaths check). Perhaps we can fix configure to not pass -rpath if --disable-rpath is passed... Regards Stefan Janet(UK) is a trading name of Jisc Collections and Janet Limited, a not-for-profit company which is registered in England under No. 2881024 and whose Registered Office is at Lumen House, Library Avenue, Harwell Oxford, Didcot, Oxfordshire. OX11 0SG. VAT No. 614944238
Stefan Paetow wrote:
It's just odd that only those two modules have a hard-coded rpath, the rest are fine (and pass the check-rpaths check).
I have no idea...
Perhaps we can fix configure to not pass -rpath if --disable-rpath is passed...
Maybe. I'm trying to test 3.0.3 before it goes out the door. Alan DeKok.
No worries, Alan. It's not the end of the world if we hold off with that :-) Stefan ________________________________________ From: freeradius-devel-bounces+stefan.paetow=ja.net@lists.freeradius.org [freeradius-devel-bounces+stefan.paetow=ja.net@lists.freeradius.org] on behalf of Alan DeKok [aland@deployingradius.com] Sent: 16 April 2014 19:08 To: FreeRadius developers mailing list Subject: Re: Any reason why rlm_sql_unixodbc.so and rlm_sql_postgresql.so use hardcoded rpaths? Stefan Paetow wrote:
It's just odd that only those two modules have a hard-coded rpath, the rest are fine (and pass the check-rpaths check).
I have no idea...
Perhaps we can fix configure to not pass -rpath if --disable-rpath is passed...
Maybe. I'm trying to test 3.0.3 before it goes out the door. Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html Janet(UK) is a trading name of Jisc Collections and Janet Limited, a not-for-profit company which is registered in England under No. 2881024 and whose Registered Office is at Lumen House, Library Avenue, Harwell Oxford, Didcot, Oxfordshire. OX11 0SG. VAT No. 614944238
participants (2)
-
Alan DeKok -
Stefan Paetow