Information about branch v3.0.x
Hi, a stupid question... I see that on branch v3.0.x modules use new syntax for export symbol (with MOD_POST_AUTH,etc.). Instead in freeradius-3.0.8 it is used old syntax: extern module_t rlm_sqlippool; module_t rlm_sqlippool = {
-RLM_MODULE_INIT, -"sqlippool", -RLM_TYPE_THREAD_SAFE,>>-/* type */ -sizeof(rlm_sqlippool_t), -module_config, -mod_instantiate,>->-/* instantiation */ -NULL,>>->->-/* detach */ -{ ->-NULL,>>->-/* authentication */ ->-NULL,>>->-/* authorization */ ->-NULL,>>->-/* preaccounting */ ->-mod_accounting,>>-/* accounting */ ->-NULL,>>->-/* checksimul */ ->-NULL,>>->-/* pre-proxy */ ->-NULL,>>->-/* post-proxy */ ->-mod_post_auth>>-/* post-auth */ -}, };
This means that release 3.0.9 will use new syntax like this: extern module_t rlm_sqlippool; module_t rlm_sqlippool = { .magic = RLM_MODULE_INIT, .name = "sqlippool", .type = RLM_TYPE_THREAD_SAFE, .inst_size = sizeof(rlm_sqlippool_t), .config = module_config, .instantiate = mod_instantiate, .methods = { [MOD_ACCOUNTING] = mod_accounting, [MOD_POST_AUTH] = mod_post_auth }, }; Thank you very much in advance. Geaaru
On 29 May 2015, at 13:30, Geaaru <geaaru@gmail.com> wrote:
Hi,
a stupid question...
More of a statement...
This means that release 3.0.9 will use new syntax like this:
Yes, and you should recompile any custom modules when 3.0.9 is released. Note: That when we add new fields to that structure, with the c99 syntax it won't produce build errors, but it will change the ABI, so you should recompile modules after each release anyway. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS development team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
Ok, perfect. I wrote a patch for sqlippool module for support pre-proxy and post-proxy section that use new syntax. So, I don't need change patch for support old 3.0.8 release if it will be release soon a 3.0.9 version. I will create a pull request tomorrow. Thanks G. On May 29, 2015 20:34, "Arran Cudbard-Bell" <a.cudbardb@freeradius.org> wrote:
On 29 May 2015, at 13:30, Geaaru <geaaru@gmail.com> wrote:
Hi,
a stupid question...
More of a statement...
This means that release 3.0.9 will use new syntax like this:
Yes, and you should recompile any custom modules when 3.0.9 is released.
Note: That when we add new fields to that structure, with the c99 syntax it won't produce build errors, but it will change the ABI, so you should recompile modules after each release anyway.
Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS development team
FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
participants (2)
-
Arran Cudbard-Bell -
Geaaru