[v4.0.x] dhcpclient - autoloading of base DHCP attributes
Hello, It seems that this recent commit broke dhcpclient : https://github.com/FreeRADIUS/freeradius-server/commit/b8d01b77a5889d56002ef... Function fr_pair_find_by_da is called with da = NULL. The offending line is (fr_dhcpv4_encode) : src/protocols/dhcpv4/base.c:295 vp = fr_pair_find_by_da(vps, attr_dhcp_opcode, TAG_ANY); Autoloading of base DHCP attributes does not seem to work. Not sure how to fix this though, can you look into this ? Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On May 22, 2018, at 10:10 AM, Chaigneau, Nicolas <nicolas.chaigneau@capgemini.com> wrote:
Autoloading of base DHCP attributes does not seem to work. Not sure how to fix this though, can you look into this ?
The code should call fr_dhcpv4_init() to autoload the attributes. The rlm_dhcpv4 module does this, but proto_dhcpv4 does not. I'll push a fix. Alan DeKok.
Thanks Alan. Your fix does not solve the issue for dhcpclient though. I think you need to call fr_dhcpv4_init() also in dhcpclient.c (tried that, and it works again). Regards, Nicolas.
Autoloading of base DHCP attributes does not seem to work. Not sure how to fix this though, can you look into this ?
The code should call fr_dhcpv4_init() to autoload the attributes. The rlm_dhcpv4 module does this, but proto_dhcpv4 does not.
I'll push a fix.
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On May 22, 2018, at 10:43 AM, Chaigneau, Nicolas <nicolas.chaigneau@capgemini.com> wrote:
Your fix does not solve the issue for dhcpclient though. I think you need to call fr_dhcpv4_init() also in dhcpclient.c (tried that, and it works again).
Thanks. I've pushed a fix. Alan DeKok.
participants (2)
-
Alan DeKok -
Chaigneau, Nicolas