Alan DeKok wrote:
If people would be interested, it can be added to the CVS tree (pending Alan's approval).
A few comments:
Don't use RADACCTDIR "/sql-relay" in the configuration section, use "${radacctdir}/sql-relay", which is a little friendlier.
Ok.
Also, call radius_xlat on inst->path, it makes the filename configurable, too.
Ok.
I don't think that the per-accounting type queries are necessary any more, at least in the CVS head. You chould be able to save the CONF_SECTION in the module instance struct, and call cf_pair_find(), keying off of Acct-Status-Type.
Ok. (the code example you posted in the other mail helped me a lot)
And since it's no longer relaying, it shouldn't be called sqlrelay. Maybe "sql_query_log", or something like that...
I agree. What about "rlm_sql_log" then? New version available there: http://nbk.perso.cegetel.net/sql_log.tar.gz -- Nicolas Baradakis
Nicolas Baradakis <nbk@sitadelle.com> wrote:
Ok. (the code example you posted in the other mail helped me a lot)
Good.
New version available there:
Looks good to me. I have 1 or two minor comments, but nothing serious. e.g. debugging messages if things aren't found, etc. I'd say it's good to go. Very nice. Also, update "radiusd.conf.in" with configuration examples, and "src/modules/stable", as there's so little code it doesn't hurt to mark it stable. And if you get enthusiastic, "man" pages would be good, too. Alan DeKok.
participants (2)
-
Alan DeKok -
Nicolas Baradakis