Alan DeKok wrote:

Here's my review:

Patches 01, (and related) 19, 20 - Don't put changes to a function prototype in a *separate* patch from changes to the source file. This breaks the build.

Patches 11, 12, 13, 14, 15, 16 - OTP code. I'll let Frank review them.

Patches 05, 06, 07, 08, 10, - adding function prototypes to remove warnings is good. But they belong in a header file, not in a C file.

Many of the rest are minor, and have no impact other than messages when building. i.e. these are low priority items.

Agree! But i have a question, as a user, what's your opion about a program producing warning messages? thanks for your review! Tinggong