[master] Unintended renaming of DHCP-Requested-IP-Address ?
Hello, One minor issue that I noticed. I think the following commit had an unintended renaming of DHCP attribute « DHCP-Requested-IP-Address » : https://github.com/FreeRADIUS/freeradius-server/commit/155fe50caa079def1bd92... It is now : ATTRIBUTE Requested-IP-Address 50 ipaddr I assume a global sed on « DHCP-Request » caused this change. Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On Dec 2, 2020, at 5:36 AM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel@lists.freeradius.org> wrote:
One minor issue that I noticed. I think the following commit had an unintended renaming of DHCP attribute « DHCP-Requested-IP-Address » :
https://github.com/FreeRADIUS/freeradius-server/commit/155fe50caa079def1bd92...
It is now :
ATTRIBUTE Requested-IP-Address 50 ipaddr
I assume a global sed on « DHCP-Request » caused this change.
Yes. I've pushed a fix. To be honest, now that we have protocol-specific namespaces, there's no need to prefix all of the DHCP option names with "DHCP-". So we'll go fix that soon, too. Alan DeKok.
One minor issue that I noticed. I think the following commit had an unintended renaming of DHCP attribute « DHCP-Requested-IP-Address » :
https://github.com/FreeRADIUS/freeradius-server/commit/155fe50caa079def1bd92...
It is now :
ATTRIBUTE Requested-IP-Address 50 ipaddr
I assume a global sed on « DHCP-Request » caused this change.
Yes. I've pushed a fix.
Thanks. You've missed a few more though (doc + modules and sites conf)... but maybe there's no need to bother if you plan to change the names again in the near future :)
To be honest, now that we have protocol-specific namespaces, there's no need to prefix all of the DHCP option names with "DHCP-". So we'll go fix that soon, too.
As I understand, they will be used as follows ? dhcpv4.Requested-IP-Address Note: at the moment this doesn't work (still in progress I assume ?) with dhcpclient: dhcpclient: Unknown attribute "dhcpv4" Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On Dec 2, 2020, at 12:35 PM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel@lists.freeradius.org> wrote:
You've missed a few more though (doc + modules and sites conf)... but maybe there's no need to bother if you plan to change the names again in the near future :)
I'll fix them for now, but yes. We plan on changing the names.
As I understand, they will be used as follows ?
dhcpv4.Requested-IP-Address
Mostly... if you already know that the protocol is DHCPv4, there's no need to add that qualifier.
Note: at the moment this doesn't work (still in progress I assume ?) with dhcpclient:
dhcpclient: Unknown attribute "dhcpv4"
That's because it already knows it's using the DHCPv4 dictionaries. Just drop the "dhcpv4." prefix. The same goes for virtual servers. Alan DeKok.
On Dec 2, 2020, at 11:59 AM, Alan DeKok <aland@deployingradius.com> wrote:
On Dec 2, 2020, at 12:35 PM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel@lists.freeradius.org> wrote:
You've missed a few more though (doc + modules and sites conf)... but maybe there's no need to bother if you plan to change the names again in the near future :)
I'll fix them for now, but yes. We plan on changing the names.
I've now changed all the names. I did say in my previous email that we would be changing all the names. I changed that particular name on purpose, as a test, as it's one of the most referenced. -Arran
Ah, sorry then. I assumed wrongly. :/ My mistake.
I've now changed all the names. I did say in my previous email that we would be changing all the names. I changed that particular name on purpose, as a test, as it's one of the most referenced.
-Arran This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
participants (3)
-
Alan DeKok -
Arran Cudbard-Bell -
Chaigneau, Nicolas