pull request @292 discusstion requirement
hi, all guys and administrators, I have a pull request #292 about ipv6 issue on master brach src/lib/misc.c, fr_ipaddr_cmp() | | #ifdef HAVE_STRUCT_SOCKADDR_IN6 | | case AF_INET6: | | - if (a->scope < b->scope) return -1; | | - if (a->scope > b->scope) return +1; | | - | | return memcmp(&a->ipaddr.ip6addr, | | | this fix according to my test configuration, 1. problem 1.1 /usr/local/etc/raddb/clients.conf, add link local client client fe80::/16 { secret = cameo shortname = atgs950 } 1.2 /usr/local/etc/raddb/sites-available/default, open ipv6 auth and acct: ipv6addr = :: # any. ::1 == localhost 1.3 client send auth request, server debug info as below: Wed May 22 11:18:57 2013 : Error: Ignoring request to auth interface eth0 address :: port 1812 as server default from unknown client fe80::290:c0ff:fe82:1630 port 49153 proto udp 2. I realy think scope is not necessary as a rb-tree key, for ip address will be unique and represent the scope "global", "link", "site", and it's transport issue 3. I also found no place to parse configured address's scope id anyone can tell me if it's code issue or not? please help review pull request, thanks
participants (1)
-
yuanlinyu