A small patch for building on Solaris and Illumos
Hello, I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required: src/include/sysutmp.h: Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux) src/include/libradius.h After line 74: +#if defined(__sun) + typedef void(*sig_t)(int); +#endif + -- Ian.
On 23 Mar 2014, at 20:34, Ian Collins <ian@ianshome.com> wrote:
Hello,
I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required:
src/include/sysutmp.h:
Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux)
Out of interest what's the significant of __sun over sun or __sun__?
src/include/libradius.h After line 74:
+#if defined(__sun) + typedef void(*sig_t)(int); +#endif +
And that's probably handled better as an autoconf check. FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
Arran Cudbard-Bell wrote:
On 23 Mar 2014, at 20:34, Ian Collins <ian@ianshome.com> wrote:
Hello,
I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required:
src/include/sysutmp.h:
Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux) Out of interest what's the significant of __sun over sun or __sun__?
__sun is defined by both gcc and Solaris Studio compilers, it is the recognised macro for detecting Solaris. -- Ian.
On 23 Mar 2014, at 22:14, Ian Collins <ian@ianshome.com> wrote:
Arran Cudbard-Bell wrote:
On 23 Mar 2014, at 20:34, Ian Collins <ian@ianshome.com> wrote:
Hello,
I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required:
src/include/sysutmp.h:
Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux) Out of interest what's the significant of __sun over sun or __sun__?
__sun is defined by both gcc and Solaris Studio compilers, it is the recognised macro for detecting Solaris.
Fair enough, fixes in all branches. Thanks for the patches. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
Arran Cudbard-Bell wrote:
On 23 Mar 2014, at 20:34, Ian Collins <ian@ianshome.com> wrote:
Hello,
I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required:
src/include/sysutmp.h:
Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux) Out of interest what's the significant of __sun over sun or __sun__?
Hello again, I finally got around to refreshing my build and I checked the v2 branch out of git (as described at http://git.freeradius.org/) and it looks like the symbol has been changed to _sun rather that __sun (note the double underscore).
src/include/libradius.h After line 74:
+#if defined(__sun) + typedef void(*sig_t)(int); +#endif + And that's probably handled better as an autoconf check.
Was this added anywhere? I can't see it. -- Ian.
On 6 May 2014, at 03:47, Ian Collins <ian@ianshome.com> wrote:
Arran Cudbard-Bell wrote:
On 23 Mar 2014, at 20:34, Ian Collins <ian@ianshome.com> wrote:
Hello,
I would like to submit a small patch to enable clean building of 2.2.4 on Solaris 11 and Illumos. Only two small changes are required:
src/include/sysutmp.h:
Line 17: -#if !defined(sun) && !defined(sgi) && !defined(hpux) +#if !defined(__sun) && !defined(sgi) && !defined(hpux) Out of interest what's the significant of __sun over sun or __sun__?
Hello again,
I finally got around to refreshing my build and I checked the v2 branch out of git (as described at http://git.freeradius.org/) and it looks like the symbol has been changed to _sun rather that __sun (note the double underscore).
src/include/libradius.h After line 74:
+#if defined(__sun) + typedef void(*sig_t)(int); +#endif + And that's probably handled better as an autoconf check.
Was this added anywhere? I can't see it.
Yes to both v3.0.x and master branches. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
participants (2)
-
Arran Cudbard-Bell -
Ian Collins