Commit report for master branch
New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add instance to application name Arran Cudbard-Bell@2014-05-26T22:22:52Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_postgresql/rlm_sql_postgresql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/8d564490014494c30ba0b... ====== Should be error message Arran Cudbard-Bell@2014-05-26T21:29:05Z Files modified: * src/main/tls.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/dcabc9782952a24f0d230... ====== Add asserts to radlog functions Arran Cudbard-Bell@2014-05-26T21:27:49Z Files modified: * src/main/log.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/1dfc79750070ec15a3df4... ====== rm unused goto Arran Cudbard-Bell@2014-05-26T20:47:19Z Files modified: * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/579748e15909ba975eb18... ====== This should never happen Arran Cudbard-Bell@2014-05-26T20:30:01Z Files modified: * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/049bbf46b974fdee46821... ====== Impose a hard limit on the number of reconnection attempts for rlm_sql and rlm_ldap Arran Cudbard-Bell@2014-05-26T20:16:44Z Files modified: * src/include/connection.h * src/main/connection.c * src/modules/rlm_ldap/ldap.c * src/modules/rlm_sql/sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/a6b9cc08c08ca818206b6... ====== Don't reconnect on QUERY CANCELED Arran Cudbard-Bell@2014-05-26T20:16:15Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/39bfdbe3e1523a60338b3... ====== Use the same format as other applications Arran Cudbard-Bell@2014-05-26T16:28:43Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_postgresql/rlm_sql_postgresql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7b3c58194c628f0c87155... ====== Don't delay proxy replies when there was a timeout Alan T. DeKok (via Arran Cudbard-Bell)@2014-05-26T15:46:25Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ae8731533623c1fd5492b... ====== Call rad_postauth() and send the packet from proxy_no_reply. Closes #657 Alan T. DeKok (via Arran Cudbard-Bell)@2014-05-26T15:46:21Z Files modified: * src/main/process.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/840428351791bfe5a04a9... ====== Tighter range constraint on INTEGER types Arran Cudbard-Bell@2014-05-26T15:45:27Z Files modified: * src/main/conffile.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/2aa169d6d08119bc366b4... ====== One last sign fix for rlm_securid Arran Cudbard-Bell@2014-05-26T15:23:01Z Files modified: * src/modules/rlm_securid/rlm_securid.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/674574b8e1986a36b1b01... ====== Typo Arran Cudbard-Bell@2014-05-26T15:03:44Z Files modified: * src/include/conffile.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/d9914b878688e084569de... ====== Use signed int to represent epoch in rlm_cache Arran Cudbard-Bell@2014-05-26T14:47:51Z Files modified: * src/modules/rlm_cache/rlm_cache.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/05077ef052b4b95da9e46... ====== Cast interval values to ints before use, so we don't get sign issues with time_t. Fixes #659 Arran Cudbard-Bell@2014-05-26T14:38:12Z Files modified: * src/main/command.c * src/main/detail.c * src/main/realms.c * src/main/threads.c * src/main/tls.c * src/modules/rlm_eap/mem.c * src/modules/rlm_otp/rlm_otp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/b4885af1dee1d13941845... ====== Merge pull request #658 from spbnick/rlm_eap_const_fix Fix compilation of rlm_eap Arran Cudbard-Bell@2014-05-26T13:31:49Z Files modified: * src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/ee5bc3553eee597005c1d... ====== Fix compilation of rlm_eap Mark rlm_eap_tnc connection_string const to cater to FR_CONF_OFFSET invocation. This fixes the build of rlm_eap module. Nikolai Kondrashov@2014-05-26T13:26:41Z Files modified: * src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/df062d12a078a8d707dad... ====== Doing it the smart way causes Doxygen errors Arran Cudbard-Bell@2014-05-26T13:25:58Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_postgresql/rlm_sql_postgresql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/89d0275f8de62af64ca25... ====== Move db_string building into the pg instantiation function Add application_name to the db_string Arran Cudbard-Bell@2014-05-26T13:22:35Z Files modified: * src/modules/rlm_sql/drivers/rlm_sql_postgresql/rlm_sql_postgresql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/af61a84809776ab34c520... ====== Add compile time checking for config pointers Arran Cudbard-Bell@2014-05-26T00:10:08Z Files modified: * src/include/conffile.h * src/include/detail.h * src/include/libradius.h * src/include/packet.h * src/include/radiusd.h * src/include/realms.h * src/include/tcp.h * src/include/tls-h * src/lib/getaddrinfo.c * src/lib/misc.c * src/lib/packet.c * src/lib/radius.c * src/lib/tcp.c * src/lib/udpfromto.c * src/main/auth.c * src/main/client.c * src/main/command.c * src/main/conffile.c * src/main/detail.c * src/main/listen.c * src/main/process.c * src/main/radclient.c * src/main/radiusd.c * src/main/radmin.c * src/main/realms.c * src/main/session.c * src/main/threads.c * src/main/tls.c * src/main/unittest.c * src/main/util.c * src/modules/proto_bfd/bfd.c * src/modules/proto_dhcp/dhcp.c * src/modules/proto_dhcp/dhcpclient.c * src/modules/proto_dhcp/dhcpd.c * src/modules/proto_vmps/vqp.c * src/modules/rlm_always/rlm_always.c * src/modules/rlm_attr_filter/rlm_attr_filter.c * src/modules/rlm_cache/rlm_cache.c * src/modules/rlm_counter/rlm_counter.c * src/modules/rlm_date/rlm_date.c * src/modules/rlm_detail/rlm_detail.c * src/modules/rlm_eap/radeapclient.c * src/modules/rlm_eap/rlm_eap.c * src/modules/rlm_eap/rlm_eap.h * src/modules/rlm_eap/types/rlm_eap_gtc/rlm_eap_gtc.c * src/modules/rlm_eap/types/rlm_eap_ikev2/rlm_eap_ikev2.c * src/modules/rlm_eap/types/rlm_eap_mschapv2/rlm_eap_mschapv2.c * src/modules/rlm_eap/types/rlm_eap_peap/rlm_eap_peap.c * src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.c * src/modules/rlm_eap/types/rlm_eap_pwd/eap_pwd.h * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.c * src/modules/rlm_eap/types/rlm_eap_pwd/rlm_eap_pwd.h * src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c * src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.h * src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c * src/modules/rlm_eap/types/rlm_eap_ttls/rlm_eap_ttls.c * src/modules/rlm_example/rlm_example.c * src/modules/rlm_exec/rlm_exec.c * src/modules/rlm_expr/rlm_expr.c * src/modules/rlm_files/rlm_files.c * src/modules/rlm_idn/rlm_idn.c * src/modules/rlm_ippool/rlm_ippool.c * src/modules/rlm_ippool/rlm_ippool_tool.c * src/modules/rlm_krb5/rlm_krb5.c * src/modules/rlm_ldap/ldap.h * src/modules/rlm_ldap/rlm_ldap.c * src/modules/rlm_linelog/rlm_linelog.c * src/modules/rlm_logintime/rlm_logintime.c * src/modules/rlm_mschap/rlm_mschap.c * src/modules/rlm_otp/extern.h * src/modules/rlm_otp/rlm_otp.c * src/modules/rlm_pam/rlm_pam.c * src/modules/rlm_pap/rlm_pap.c * src/modules/rlm_perl/rlm_perl.c * src/modules/rlm_preprocess/rlm_preprocess.c * src/modules/rlm_python/rlm_python.c * src/modules/rlm_radutmp/rlm_radutmp.c * src/modules/rlm_realm/rlm_realm.c * src/modules/rlm_redis/rlm_redis.c * src/modules/rlm_redis/rlm_redis.h * src/modules/rlm_rediswho/rlm_rediswho.c * src/modules/rlm_rest/rest.h * src/modules/rlm_rest/rlm_rest.c * src/modules/rlm_securid/rlm_securid.c * src/modules/rlm_securid/rlm_securid.h * src/modules/rlm_smsotp/rlm_smsotp.c * src/modules/rlm_soh/rlm_soh.c * src/modules/rlm_sometimes/rlm_sometimes.c * src/modules/rlm_sql/drivers/rlm_sql_mysql/rlm_sql_mysql.c * src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c * src/modules/rlm_sql/rlm_sql.c * src/modules/rlm_sql/rlm_sql.h * src/modules/rlm_sqlcounter/rlm_sqlcounter.c * src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c * src/modules/rlm_sqlippool/rlm_sqlippool.c * src/modules/rlm_unbound/rlm_unbound.c * src/modules/rlm_unix/rlm_unix.c * src/modules/rlm_wimax/rlm_wimax.c * src/modules/rlm_yubikey/rlm_yubikey.c * src/modules/rlm_yubikey/rlm_yubikey.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/7106addf1caf56397dbf6... ====== -- This commit summary was generated @2014-05-27T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).
A better way than doing strstr for application_name might be to set fallback_application_name? -- Sent from my phone with, please excuse brevity and typos
On 27 May 2014, at 00:15, Phil Mayers <p.mayers@imperial.ac.uk> wrote:
A better way than doing strstr for application_name might be to set fallback_application_name?
I'm ok with that so long as you know for certain it won't cause a connection failure for versions it's not implemented for? The discussion on Google was from 2011. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On 27 May 2014, at 00:33, Arran Cudbard-Bell <a.cudbardb@freeradius.org> wrote:
On 27 May 2014, at 00:15, Phil Mayers <p.mayers@imperial.ac.uk> wrote:
A better way than doing strstr for application_name might be to set fallback_application_name?
I'm ok with that so long as you know for certain it won't cause a connection failure for versions it's not implemented for? The discussion on Google was from 2011.
* Discussion from google where they were talking about implementing it. I've seen other posts where unrecognised options in the connection string cause opening connections to fail Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
Correct. So hard-coding this in the source is probably a bad idea all round :o( Maybe just add some way to append extra DSN options, and put an example in the config files.
On 27 May 2014, at 12:54, Phil Mayers <p.mayers@IMPERIAL.AC.UK> wrote:
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
Correct. So hard-coding this in the source is probably a bad idea all round :o(
You're probably right. Application name was only added in 9.0. It's a shame we can't get the remote version before building the connection string. Oh well. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On 27 May 2014, at 15:49, Arran Cudbard-Bell <a.cudbardb@freeradius.org> wrote:
On 27 May 2014, at 12:54, Phil Mayers <p.mayers@IMPERIAL.AC.UK> wrote:
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
Correct. So hard-coding this in the source is probably a bad idea all round :o(
You're probably right. Application name was only added in 9.0. It's a shame we can't get the remote version before building the connection string. Oh well.
Done. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
FYI, I can't run current HEAD, because it's sending application_name, and does not seem to be obeying the: postgres { send_application_name = no } ...config I've had to add (also it's really annoying I had to add it. It's a config compat break in the middle of a train. Please default it to no)
On 13/06/14 13:35, Phil Mayers wrote:
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
FYI, I can't run current HEAD, because it's sending application_name, and does not seem to be obeying the:
postgres { send_application_name = no }
Ah, that's because it should be "postgresql". Note the example in the default config is therefore wrong.
On 13 Jun 2014, at 13:36, Phil Mayers <p.mayers@imperial.ac.uk> wrote:
On 13/06/14 13:35, Phil Mayers wrote:
On 27/05/14 12:04, Arran Cudbard-Bell wrote:
I've seen other posts where unrecognised options in the connection string cause opening connections to fail
FYI, I can't run current HEAD, because it's sending application_name, and does not seem to be obeying the:
postgres { send_application_name = no }
Ah, that's because it should be "postgresql". Note the example in the default config is therefore wrong.
Fixed, thanks. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
participants (3)
-
announce＠freeradius.org -
Arran Cudbard-Bell -
Phil Mayers