Automatic report from sources (radiusd) between 16.08.2006 - 17.08.2006 GMT
CVS log entries from 16.08.2006 (Wed) 08:00:01 - 17.08.2006 (Thu) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/radius.c; Revisions: 1.187, 1.125.2.5.2.8 Author: nbk File: radiusd/src/include/Makefile; Revisions: 1.4, 1.2.4.1 Author: pnixon File: radiusd/doc/examples/postgresql.sql; Revisions: 1.1.2.3 File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revisions: 1.3.2.3 File: radiusd/doc/rlm_sqlippool; Revisions: 1.1, 1.1.2.1 ===================================================== Combined list of identical log entries ===================================================== Description: Regenerate radpaths.h if a later run of ./configure has rewritten build-radpaths-h. This prevents from using the pathnames of the previous build, which won't work if the configure options were different. Modified files: File: radiusd/src/include/Makefile; Revision: 1.4; Date: 2006/08/16 21:42:30; Author: nbk; Lines: (+3 -5) File: radiusd/src/include/Makefile; Revision: 1.2.4.1; Date: 2006/08/16 21:43:18; Author: nbk; Lines: (+3 -5) ------------------------------- Description: Some initial sqlippool documentation and schema update Modified files: File: radiusd/doc/rlm_sqlippool; Revision: 1.1.2.1; Date: 2006/08/16 17:42:25; Author: pnixon; Lines: (+28 -0) File: radiusd/doc/examples/postgresql.sql; Revision: 1.1.2.3; Date: 2006/08/16 17:42:26; Author: pnixon; Lines: (+3 -3) ===================================================== Log entries ===================================================== Description: file rlm_sqlippool was initially added on branch branch_1_1. Modified files: File: radiusd/doc/rlm_sqlippool; Revision: 1.1; Date: 2006/08/16 17:42:25; Author: pnixon; ------------------------------- Description: Verify Access-Challenge, too. Bug found by Mitaine Yoann Modified files: File: radiusd/src/lib/radius.c; Revision: 1.187; Date: 2006/08/16 20:04:33; Author: aland; Lines: (+3 -2) ------------------------------- Description: Verify Access-Challenge, too. That's a dumb bug, found by Mitaine Yoann Modified files: File: radiusd/src/lib/radius.c; Revision: 1.125.2.5.2.8; Date: 2006/08/16 20:03:35; Author: aland; Lines: (+3 -2) ------------------------------- Description: Major updates to module to make it standalone. It no longer needs to know what the ip pool config is at startup, infact it no longer cares as each query is check against the table so new pools can be added, deleted and extended on the fly without a reload. Modified files: File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revision: 1.3.2.3; Date: 2006/08/16 17:06:49; Author: pnixon; Lines: (+35 -33) ===================================================== Summary of modified files ===================================================== File: radiusd/doc/examples/postgresql.sql Revisions: 1.1.2.3 Authors: pnixon (+3 -3) ------------------------------- File: radiusd/doc/rlm_sqlippool Revisions: 1.1, 1.1.2.1 Authors: pnixon, pnixon (+28 -0) ------------------------------- File: radiusd/src/include/Makefile Revisions: 1.4, 1.2.4.1 Authors: nbk (+3 -5), nbk (+3 -5) ------------------------------- File: radiusd/src/lib/radius.c Revisions: 1.187, 1.125.2.5.2.8 Authors: aland (+3 -2), aland (+3 -2) ------------------------------- File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c Revisions: 1.3.2.3 Authors: pnixon (+35 -33) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl
Major updates to module to make it standalone. It no longer needs to know what the ip pool config is at startup, infact it no longer cares as each query is check against the table so new pools can be added, deleted and extended on the fly without a reload.
Wow... that's astonishingly useful. Alan DeKok. -- http://deployingradius.com - The web site of the book http://deployingradius.com/blog/ - The blog
On Thu 17 Aug 2006 18:00, Alan DeKok wrote:
Major updates to module to make it standalone. It no longer needs to know what the ip pool config is at startup, infact it no longer cares as each query is check against the table so new pools can be added, deleted and extended on the fly without a reload.
Wow... that's astonishingly useful.
Heh. Thanks. It fits in nicely with the rest of my plan to take over the world :-) We have the this code in production and it seems to be solid so far. The one this that it doesn't do which I would like is try to hand out the same IP that you had before. It is possible to do this, but I can't see any way without transitioning from one sql query to a stored procedure containing 3 queries which will be considerably slower. If I have a brainwave about how to do this cleaner I will certainly commit it, but for now you are almost guaranteed to get a different IP each time as the module hands out IPs sequentially from the pool. Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
Peter Nixon <listuser@peternixon.net> wrote:
Heh. Thanks. It fits in nicely with the rest of my plan to take over the world :-)
Sounds good to me.
We have the this code in production and it seems to be solid so far.
Comments: over-writing data->pool_name, even with a mutex lock, is a bad idea. Get rid of the mutex lock, and when decoding 'P', do: ... case 'P': { const char *x = data->pool_name; VALUE_PAIR *vp = pairfind(request->config_items, PW_POOL_NAME); if (vp) x = data->strvalue; strNcpy(q, x, freespace); q + strlen(q); } ... That *should* work, once you add "REQUEST *request" to the function arguments. Other than that, I've poked it to build in the CVS head, and committed it there. It's untested, though. Some comments: add a "user key" field to the table, which is a unique per-use key. e.g. MAC address, username, etc. When allocating, do a SELECT on the key first, and an entry exists that's marked unused, allocate it. The key will also help for accounting packets, too. Alan DeKok. -- http://deployingradius.com - The web site of the book http://deployingradius.com/blog/ - The blog
participants (3)
-
Alan DeKok -
Automatic cvs log generator -
Peter Nixon