Without the following conf.patch, I can't start radiusd because: including configuration file /usr/local/etc/raddb/radiusd.conf including configuration file /usr/local/etc/raddbclients.conf ^^ note the missing separator. That ++p fixes it. conffiles.c also uses stat independently of dirent, so moving that #endif to enable is useful. I also include essentially a documentation patch for comments - I hope the files are the ones I think are meant to be referenced. Cheers, Patrick
Patrick Welche wrote:
Without the following conf.patch, I can't start radiusd because:
including configuration file /usr/local/etc/raddb/radiusd.conf including configuration file /usr/local/etc/raddbclients.conf ^^ note the missing separator. That ++p fixes it.
conffiles.c also uses stat independently of dirent, so moving that #endif to enable is useful.
Fixed, thanks. I also fixed the issue in rlm_eap.
I also include essentially a documentation patch for comments - I hope the files are the ones I think are meant to be referenced.
I'll check this in more detail later today. Alan DeKok.
On Tue, Nov 13, 2007 at 07:57:59AM +0100, Alan DeKok wrote:
Patrick Welche wrote: ...
I also include essentially a documentation patch for comments - I hope the files are the ones I think are meant to be referenced.
I'll check this in more detail later today.
BTW I commented out the DATE_SUB function in raddb/sql/postgresql/schema.sql because it is not needed and is a vestige of the one schema being used by several sql backends - you could delete the whole thing starting from /* * Note: (pnixon: 2003-12-10) The following function should not be required Cheers, Patrick
On Thu 15 Nov 2007, Patrick Welche wrote:
On Tue, Nov 13, 2007 at 07:57:59AM +0100, Alan DeKok wrote:
Patrick Welche wrote:
...
I also include essentially a documentation patch for comments - I hope the files are the ones I think are meant to be referenced.
I'll check this in more detail later today.
BTW I commented out the DATE_SUB function in raddb/sql/postgresql/schema.sql because it is not needed and is a vestige of the one schema being used by several sql backends - you could delete the whole thing starting from
/* * Note: (pnixon: 2003-12-10) The following function should not be required
Yep. As the comment says its not required. We can probably remove it now that the modifications I made which removed its use have been in production for 4 years :-) -- Peter Nixon http://peternixon.net/
participants (3)
-
Alan DeKok -
Patrick Welche -
Peter Nixon