update mods-available:sql suggestion
In order to standardize configuration more, we could just use below default configuration: +++ /etc/freeradius/mods-available/sql 2020-03-03 16:09:11.306618514 +0100 @@ -30,6 +30,7 @@ # # Allowed dialects are: # + # null # mssql # mysql # oracle @@ -37,7 +38,7 @@ # sqlite # mongo # - dialect = "sqlite" + dialect = "null" # # The driver module used to execute the queries. Since we @@ -58,8 +59,7 @@ # rlm_sql_unixodbc # rlm_sql_mongo # - driver = "rlm_sql_null" -# driver = "rlm_sql_${dialect}" + driver = "rlm_sql_${dialect}"
On Mar 3, 2020, at 10:12 AM, Jonathan <huffelduffel@gmail.com> wrote:
In order to standardize configuration more, we could just use below default configuration:
OK..
+++ /etc/freeradius/mods-available/sql 2020-03-03 16:09:11.306618514 +0100 @@ -30,6 +30,7 @@ # # Allowed dialects are: # + # null # mssql
No, there is no SQL syntax called "null".
@@ -37,7 +38,7 @@ # sqlite # mongo # - dialect = "sqlite" + dialect = "null"
The dialect is used to select which SQL queries are used. The "null" driver just logs SQL queries to a file. So it has to log *something*. It can't log a "null" SQL dialect, as it doesn't exist.
# # The driver module used to execute the queries. Since we @@ -58,8 +59,7 @@ # rlm_sql_unixodbc # rlm_sql_mongo # - driver = "rlm_sql_null" -# driver = "rlm_sql_${dialect}" + driver = "rlm_sql_${dialect}"
See above. This change will make the default configuration fail to start, because of the final line in the module: # Read database-specific queries $INCLUDE ${modconfdir}/${.:name}/main/${dialect}/queries.conf There is no such file as raddb/mods-config/sql/main/null/queries.conf" Alan DeKok.
participants (2)
-
Alan DeKok -
Jonathan