v2.x.x - ENABLE_OPENSSL_VERSION_CHECK
I'm aware v2.x.x is EOL, reporting this just in case you're still correcting defects. In this commit: https://github.com/FreeRADIUS/freeradius-server/commit/4f24d4cda8b43b5f70311... ENABLE_OPENSSL_VERSION_CHECK is removed from around ssl_check_version. However allow_vulnerable_openssl is still wrapped by that condition in mainconfig.c and radiusd.h, so building with --disable-openssl_version_check fails as mainconfig is checked for a non-existent member. I think simply removing the condition from mainconfig.c and radiusd.h is sufficient (or should it be protected with HAVE_OPENSSL_CRYPTO_H?) - I could create a pull doing either of those if desired. Regards, Adam Bishop gpg: 0x6609D460 jisc.ac.uk | Networkshop 44: Save the date! | 22-24 March 2016 @ University of Manchester Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.
On Dec 9, 2015, at 1:29 PM, Adam Bishop <Adam.Bishop@jisc.ac.uk> wrote:
I'm aware v2.x.x is EOL, reporting this just in case you're still correcting defects.
In this commit:
https://github.com/FreeRADIUS/freeradius-server/commit/4f24d4cda8b43b5f70311...
ENABLE_OPENSSL_VERSION_CHECK is removed from around ssl_check_version.
However allow_vulnerable_openssl is still wrapped by that condition in mainconfig.c and radiusd.h, so building with --disable-openssl_version_check fails as mainconfig is checked for a non-existent member.
I think simply removing the condition from mainconfig.c and radiusd.h is sufficient (or should it be protected with HAVE_OPENSSL_CRYPTO_H?) - I could create a pull doing either of those if desired.
Send a pull request please. -Arran
participants (2)
-
Adam Bishop -
Arran Cudbard-Bell