Fwd: master branch: dhcp and ATTR_FLAGS.encoded: few questions.
I try to compile freeradius trunk with WITH_DHCP flags, found few issues: 1. encoded bit-field is removed from ATTR_FLAGS. (bit it still used in dhcp.c, so compilation is broken) It's correct, that check of encoded field can be safely removed from dhcp, becouse this flag was used to reflect stage of packet processing, not stage of flag ? 2. in ATTRF_FLAGS size of do_xlat bitfueld is set to zero (at the same time we have assigments to flags.do_xlat in src/main/valuepair.c) Is it correct, that this is just typo and do_xlat must be declared with 1 bit ? 3. listener.c contains reference to undfined function fr_ipaddr_any. Is it correct, that fr_ipaddr_any must be defined as if ((sock->port == port) && ((sock->ipaddr.af == AF_INET) && (sock->ipaddr.ipaddr.ip4addr.s_addr == INADDR_ANY))) { return this; } #ifdef HAVE_STRUCT_SOCKADDR_IN6 if ((sock->port == port) && (sock->ipaddr.af == AF_INET6) && (IN6_IS_ADDR_UNSPECIFIED(&sock->ipaddr.ipaddr.ip6addr))) { return this; } #endif and it was simple forgotten to be comitted ? Regards !
Ruslan Shevchenko wrote:
I try to compile freeradius trunk with WITH_DHCP flags, found few issues:
1. encoded bit-field is removed from ATTR_FLAGS. (bit it still used in dhcp.c, so compilation is broken) It's correct, that check of encoded field can be safely removed from dhcp, becouse this flag was used to reflect stage of packet processing, not stage of flag ?
Yes, that needs to be fixed.
2. in ATTRF_FLAGS size of do_xlat bitfueld is set to zero
? Nope. It's a 1-bit bitfield.
3. listener.c contains reference to undfined function fr_ipaddr_any.
That's a typo. I'll commit a fix. Alan DeKok.
On Fri, May 6, 2011 at 12:18 PM, Alan DeKok <aland@deployingradius.com> wrote:
Ruslan Shevchenko wrote:
I try to compile freeradius trunk with WITH_DHCP flags, found few issues:
1. encoded bit-field is removed from ATTR_FLAGS. (bit it still used in dhcp.c, so compilation is broken) It's correct, that check of encoded field can be safely removed from dhcp, becouse this flag was used to reflect stage of packet processing, not stage of flag ?
Yes, that needs to be fixed.
Thanks. I pulled appropriative changed into github
2. in ATTRF_FLAGS size of do_xlat bitfueld is set to zero
? Nope. It's a 1-bit bitfield.
//strange, git diff uses no changes now //[may be something with my memory ..]
3. listener.c contains reference to undfined function fr_ipaddr_any.
That's a typo. I'll commit a fix.
Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
participants (2)
-
Alan DeKok -
Ruslan Shevchenko