rlm_sql_iodbc wrong parameter parsing
I think I found a bug in module rlm_sql_iodbc. The problem is located in rlm_sql_iodbc driver, in the SQLConnect function. The function's signature requires sql_server as second parameter (config->sql_server), but the sql_db one was provided (config->sql_db). This bug forces to set the configuration parameter "radius_db" to the system DSN only for iodbc module, differing from the ODBC one where the "server" parameter is used. I opened the bug https://bugs.freeradius.org/bugzilla/show_bug.cgi?id=150 in which I attached a patch that solves the problem. Hope this helps. Thank you for your interest.
Angelo Compagnucci wrote:
I think I found a bug in module rlm_sql_iodbc. ... I opened the bug https://bugs.freeradius.org/bugzilla/show_bug.cgi?id=150 in which I attached a patch that solves the problem.
It's been fixed, thanks. Alan DeKok.
Can I declare bug as CLOSED on bugzilla? 2011/6/8 Alan DeKok <aland@deployingradius.com>:
Angelo Compagnucci wrote:
I think I found a bug in module rlm_sql_iodbc. ... I opened the bug https://bugs.freeradius.org/bugzilla/show_bug.cgi?id=150 in which I attached a patch that solves the problem.
It's been fixed, thanks.
Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
I reviewed all the rlm_sql_* modules hunting for possible other bug and I think I found another one. This time I cannot replicate an environment for testing, so I made a patch and atteched here. The bug is locate in rlm_sql_oracle module and it involves the same config->sql_db as the rlm_sql_iodbc one. Thank you for your time! 2011/6/9 Alan DeKok <aland@deployingradius.com>:
Angelo Compagnucci wrote:
Can I declare bug as CLOSED on bugzilla?
Yes.
Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
Hi list, Sorry for wrong patch submitting of the previous email. I rewrite the email correctly here: I reviewed all the rlm_sql_* modules hunting for possible other bug and I think I found another one. This time I cannot replicate an environment for testing, so I made a patch and atteched here instead of opening a new bug. The bug is locate in rlm_sql_oracle module and it involves the same config->sql_db as the rlm_sql_iodbc one. Thank you for your time! --- sql_oracle.c.orig 2010-09-28 13:03:56.000000000 +0200 +++ sql_oracle.c 2011-06-13 19:15:32.816405400 +0200 @@ -176,7 +176,7 @@ if (OCILogon(oracle_sock->env, oracle_sock->errHandle, &oracle_sock->conn, config->sql_login, strlen(config->sql_login), config->sql_password, strlen(config->sql_password), - config->sql_db, strlen(config->sql_db))) + config->sql_server, strlen(config->sql_server))) { radlog(L_ERR,"rlm_sql_oracle: Oracle logon failed: '%s'", sql_error(sqlsocket, config)); sql_close(sqlsocket,config);
participants (2)
-
Alan DeKok -
Angelo Compagnucci