1.1.2 is broken if you have closefrom()
So on Solaris, it's broken. src/include/autoconf.h.in#1.66 needs to be imported to the 1.1 branch. Probably other changes as well. (1.55 is the last change in the 1.1 branch.) It's also interesting that the freeradius closefrom() returns int (unlike solaris which returns void), yet no one uses the return value. I'd suggest just having it return void. I actually wouldn't mind adding some changes to a 1.1.3 release, if this problem warrants a new release. -frank
Frank Cusack <fcusack@fcusack.com> wrote:
So on Solaris, it's broken. src/include/autoconf.h.in#1.66 needs to be imported to the 1.1 branch. Probably other changes as well. (1.55 is the last change in the 1.1 branch.)
OK. Could you integrate those changes?
It's also interesting that the freeradius closefrom() returns int (unlike solaris which returns void), yet no one uses the return value. I'd suggest just having it return void.
OK. Other systems have it return "int", so that's what I went with.
I actually wouldn't mind adding some changes to a 1.1.3 release, if this problem warrants a new release.
Commit the changes, and we'll see about a new release. I'm not opposed, but I'd like to see some features from the CVS head going into a stable release. Alan DeKok.
On June 1, 2006 2:27:11 PM -0400 Alan DeKok <aland@nitros9.org> wrote:
Frank Cusack <fcusack@fcusack.com> wrote:
So on Solaris, it's broken. src/include/autoconf.h.in#1.66 needs to be imported to the 1.1 branch. Probably other changes as well. (1.55 is the last change in the 1.1 branch.)
OK. Could you integrate those changes?
I would, but it looks like this file is generated using autoheader. I'm not familiar with that tool. Looks like Paul and Nicolas know a lot about that.
It's also interesting that the freeradius closefrom() returns int (unlike solaris which returns void), yet no one uses the return value. I'd suggest just having it return void.
OK. Other systems have it return "int", so that's what I went with.
Ah. Well no harm leaving it.
I actually wouldn't mind adding some changes to a 1.1.3 release, if this problem warrants a new release.
Commit the changes, and we'll see about a new release. I'm not opposed, but I'd like to see some features from the CVS head going into a stable release.
If you would list the features (perhaps in bugs like for 1.1.2) I'd be happy to help with integrating. ('cept for the autoconf stuff which I'm pretty scared of) -frank
Frank Cusack wrote:
So on Solaris, it's broken. src/include/autoconf.h.in#1.66 needs to be imported to the 1.1 branch. Probably other changes as well. (1.55 is the last change in the 1.1 branch.)
I did re-run autoconf2.13 before the release, but completely forgot about autoheader2.13, sorry. I've regenerated autoconf.h.in in branch_1_1 of the CVS, so it should work better know. -- Nicolas Baradakis
On June 2, 2006 5:51:03 PM +0200 Nicolas Baradakis <nbk@sitadelle.com> wrote:
I've regenerated autoconf.h.in in branch_1_1 of the CVS, so it should work better know.
It works. I've updated the ChangeLog for a 1.1.3 release, it's ready to go unless we want to pull in some fixes from HEAD. I'd prefer to import the fixes but not at the expense of delaying 1.1.3 too much (don't want to have a broken 1.1.2 out there). I guess Alan has the best idea of what is ready to get integrated? -frank
Frank Cusack <fcusack@fcusack.com> wrote:
It works. I've updated the ChangeLog for a 1.1.3 release, it's ready to go unless we want to pull in some fixes from HEAD.
No. I'd prefer to do that as part of ongoing work in 1.2, 1.3, etc.
I'd prefer to import the fixes but not at the expense of delaying 1.1.3 too much (don't want to have a broken 1.1.2 out there).
Are there any other serious fixes that should go into 1.1.3? Maybe the LD_LIBRARY_PATH fixes if $(R) is set? Those should go into the top-level Makefile. Alan DeKok.
On June 2, 2006 12:58:57 PM -0400 Alan DeKok <aland@nitros9.org> wrote:
Are there any other serious fixes that should go into 1.1.3? Maybe the LD_LIBRARY_PATH fixes if $(R) is set? Those should go into the top-level Makefile.
Yeah, that should definitely be fixed. I'll see if I can reproduce it. -frank
participants (3)
-
Alan DeKok -
Frank Cusack -
Nicolas Baradakis