change of behaviour on 2.2.1
Hello, We have a custom module we have been using for a while on radius 2.2.0. I yesterday compiled it against 2.2.1 and it behaved differently as it used to do with the previous version. Specifically around handling of returned from authorisation module, and I was wondering if something have changed in this version of freeradius or I made a mistake somewhere. Our module under 2.2.0 and previous versions when dealing with an authorisation request that does not require authentication it would return RLM_MODULE_HANDLED. This would result in the authentication request terminating with the reply back to the clients. Under 2.2.1 however what it has been observed is that it still drops to authentication which results in incorrect handling of the request. Is this something it has changed between versions or am I doing something which shouldn't have worked in the first place? If the latter is this the comment in the header file incorrect or misleading? RLM_MODULE_HANDLED, /* the module handled the request, so stop. */ Thank you Sergio
On 25 Sep 2013, at 08:29, srua1@plus.net wrote:
Hello,
We have a custom module we have been using for a while on radius 2.2.0. I yesterday compiled it against 2.2.1 and it behaved differently as it used to do with the previous version. Specifically around handling of returned from authorisation module, and I was wondering if something have changed in this version of freeradius or I made a mistake somewhere.
Our module under 2.2.0 and previous versions when dealing with an authorisation request that does not require authentication it would return RLM_MODULE_HANDLED. This would result in the authentication request terminating with the reply back to the clients. Under 2.2.1 however what it has been observed is that it still drops to authentication which results in incorrect handling of the request.
Is this something it has changed between versions or am I doing something which shouldn't have worked in the first place? If the latter is this the comment in the header file incorrect or misleading?
RLM_MODULE_HANDLED, /* the module handled the request, so stop. */
It seems there are issues with the return code logic in 2.2.1. Have you tried explicitly setting <module> { handled = return } ? It may just be the actions/priorities aren't being inherited correctly from the parent section. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team
Yes I had tried. It made no difference. On 25/09/2013 08:38, "Arran Cudbard-Bell" <a.cudbardb@freeradius.org> wrote:
On 25 Sep 2013, at 08:29, srua1@plus.net wrote:
Hello,
We have a custom module we have been using for a while on radius 2.2.0. I yesterday compiled it against 2.2.1 and it behaved differently as it used to do with the previous version. Specifically around handling of returned from authorisation module, and I was wondering if something have changed in this version of freeradius or I made a mistake somewhere.
Our module under 2.2.0 and previous versions when dealing with an authorisation request that does not require authentication it would return RLM_MODULE_HANDLED. This would result in the authentication request terminating with the reply back to the clients. Under 2.2.1 however what it has been observed is that it still drops to authentication which results in incorrect handling of the request.
Is this something it has changed between versions or am I doing something which shouldn't have worked in the first place? If the latter is this the comment in the header file incorrect or misleading?
RLM_MODULE_HANDLED, /* the module handled the request, so stop. */
It seems there are issues with the return code logic in 2.2.1.
Have you tried explicitly setting
<module> { handled = return }
?
It may just be the actions/priorities aren't being inherited correctly from the parent section.
Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
On 25 Sep 2013, at 08:40, srua1@plus.net wrote:
Yes I had tried. It made no difference.
OK, Alan has pushed a fix here: https://github.com/FreeRADIUS/freeradius-server/commit/f1c2629e75048ffc7eee8... There were two issues. Firstly the previous priority was overwritten if the new one was equal to the old one, it should of only been when it was higher. Second priority wasn't being re-initialised after every function call. This should fix both this issue, and the other issue with conditions in Auth-Type. -Arran Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team
On 28/09/2013 15:44, "Arran Cudbard-Bell" <a.cudbardb@freeradius.org> wrote:
Yes I had tried. It made no difference.
OK, Alan has pushed a fix here: https://github.com/FreeRADIUS/freeradius-server/commit/f1c2629e75048ffc7ee e804578b0a9fb0ca3d48d
This should fix both this issue, and the other issue with conditions in Auth-Type.
I just did a quick test using the GIT's v2.x.x branch and it seems to work fine. Thanks Sergio
srua1@plus.net wrote:
We have a custom module we have been using for a while on radius 2.2.0. I yesterday compiled it against 2.2.1 and it behaved differently as it used to do with the previous version. Specifically around handling of returned from authorisation module, and I was wondering if something have changed in this version of freeradius or I made a mistake somewhere.
I've pushed a fix. Please try the v2.x.x branch on git. If it's OK, we'll release 2.2.1 on Monday. Alan DeKok.
John Dennis wrote:
On 09/28/2013 10:44 AM, Alan DeKok wrote:
I've pushed a fix. Please try the v2.x.x branch on git. If it's OK, we'll release 2.2.1 on Monday.
You mean you'll be releasing 2.2.2 on Monday, not 2.2.1, right?
Yes. And 3.0.0 next week, too. The return code problem was the last outstanding issue. It's been WAY too long that 3.0 has been waiting. Alan DeKok.
On 28 Sep 2013, at 16:41, John Dennis <jdennis@redhat.com> wrote:
On 09/28/2013 10:44 AM, Alan DeKok wrote:
I've pushed a fix. Please try the v2.x.x branch on git. If it's OK, we'll release 2.2.1 on Monday.
You mean you'll be releasing 2.2.2 on Monday, not 2.2.1, right?
Yes. Though it would help if Alan Buxey could figure out exactly what was wrong with his system... Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team
participants (4)
-
Alan DeKok -
Arran Cudbard-Bell -
John Dennis -
srua1＠plus.net