Hi, I've adapted rlm_sql to REDIS (http://redis.io/) key-store database. It handle authorize, accounting, checksimul and post-auth (only authorize is deeply tested). Authorize works like rlm_sql with groups, etc... Files are here: http://free.oxymium.net/freeradius/rlm_redisn/ Available as .tgz here: http://free.oxymium.net/freeradius/rlm_redisn-20111112-001.tgz Manuel -- ______________________________________________________________________ Manuel Guesdon - OXYMIUM
Manuel Guesdon wrote:
I've adapted rlm_sql to REDIS (http://redis.io/) key-store database.
That sounds good, but... the rlm_sql code is pretty bad. I wouldn't suggest adapting it. Instead, start from scratch. It will be simpler, and do more. I see you've cleaned up a lot of the code, to be simpler than the SQL module. That's an important step, and very useful.
It handle authorize, accounting, checksimul and post-auth (only authorize is deeply tested). Authorize works like rlm_sql with groups, etc...
Nice.
Files are here: http://free.oxymium.net/freeradius/rlm_redisn/ Available as .tgz here: http://free.oxymium.net/freeradius/rlm_redisn-20111112-001.tgz
I'll take a look in more detail later this week. Alan DeKok.
On Sun, 13 Nov 2011 10:29:48 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > I've adapted rlm_sql to REDIS (http://redis.io/) key-store database. | | That sounds good, but... the rlm_sql code is pretty bad. I wouldn't | suggest adapting it. Instead, start from scratch. It will be simpler, | and do more. | I see you've cleaned up a lot of the code, to be simpler than the SQL | module. That's an important step, and very useful.
In fact, the choice was not easy: I've hesitated between using existing rlm_redis or write it as a rlm_sql driver or write it from scratch :-) Write it as rlm_sql driver seems not easy because rlm_sql is very sql centric (tests on queries begining with "SELECT " and using affected rows count) and doesn't support multi-queries (which is important for using redis in accounting). As I'm new to radis, write it from scratch seems a little difficult. So i've choose to write it as new module based on rlm_sql to keeps some common mecanisms (like fetch_row) so it may later be converted as a sql driver in an ehanced rtlm_sql or at least follow rlm_sql improvments more easily. And as I've no experience on accounting in radius (my primary need is authorize part) I've thank it was better to stay close to existing stuff.
| I'll take a look in more detail later this week.
Thank you. Please tell me what can be improved or modified ! Manuel -- ______________________________________________________________________ Manuel Guesdon - OXYMIUM
Hi Alan, On Sun, 13 Nov 2011 10:29:48 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > I've adapted rlm_sql to REDIS (http://redis.io/) key-store database. | | That sounds good, but... the rlm_sql code is pretty bad. I wouldn't | suggest adapting it. Instead, start from scratch. It will be simpler, | and do more. | | I see you've cleaned up a lot of the code, to be simpler than the SQL | module. That's an important step, and very useful. | | > It handle authorize, accounting, checksimul and post-auth (only authorize is | > deeply tested). | > Authorize works like rlm_sql with groups, etc... | | Nice. | | > Files are here: | > http://free.oxymium.net/freeradius/rlm_redisn/ | > Available as .tgz here: | > http://free.oxymium.net/freeradius/rlm_redisn-20111112-001.tgz | | I'll take a look in more detail later this week.
Did you found some time to take a look to the module ? Manuel -- ______________________________________________________________________ Manuel Guesdon - OXYMIUM
On Nov 25, 2011, at 9:54 AM, Alan DeKok wrote:
Manuel Guesdon wrote:
Did you found some time to take a look to the module ?
No, sorry. Maybe later…
wait a minute…I already made a redis module and it's in the latest Freeradius. see freeradius-server/src/modules/rlm_redis Why re-invent the wheel? -Gabe
Hi, On Fri, 25 Nov 2011 15:54:40 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > Did you found some time to take a look to the module ? | | No, sorry. Maybe later...
Is it possible plan integration in next Freeradius release ? Thx ! Manuel -- ______________________________________________________________________ Manuel Guesdon - OXYMIUM
Manuel Guesdon wrote:
On Fri, 25 Nov 2011 15:54:40 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > Did you found some time to take a look to the module ? | | No, sorry. Maybe later...
Is it possible plan integration in next Freeradius release ?
You're responding to a message from a year ago. You're including little or no useful information in the message. If you had bothered to look, version 2.2.0 has a redis module. If that doesn't answer your question, I have no idea what you want. Alan DeKok.
On 31 Oct 2012, at 19:10, Alan DeKok <aland@DEPLOYINGRADIUS.COM> wrote:
Manuel Guesdon wrote:
On Fri, 25 Nov 2011 15:54:40 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > Did you found some time to take a look to the module ? | | No, sorry. Maybe later...
Is it possible plan integration in next Freeradius release ?
You're responding to a message from a year ago. You're including little or no useful information in the message.
If you had bothered to look, version 2.2.0 has a redis module. If that doesn't answer your question, I have no idea what you want.
Uh, his module that implements all the redis auth autz acct logic to be merged. I still have the email thread from a year ago... But - this higlights why you should not post patches to the list, and should instead post them to GitHub, where they won't be forgotten about, and may actually get merged at some point. -Arran
On 2012-10-31, at 8:49 PM, Arran Cudbard-Bell <a.cudbardb@freeradius.org> wrote:
On 31 Oct 2012, at 19:10, Alan DeKok <aland@DEPLOYINGRADIUS.COM> wrote:
If you had bothered to look, version 2.2.0 has a redis module. If that doesn't answer your question, I have no idea what you want.
Uh, his module that implements all the redis auth autz acct logic to be merged
I guess that wasn't obvious to me. I would have preferred more of an explanation than.
I still have the email thread from a year ago... But - this higlights why you should not post patches to the list, and should instead post them to GitHub, where they won't be forgotten about, and may actually get merged at some point.
Yes. Alan DeKok.
On Wed, 31 Oct 2012 20:10:34 +0100 Alan DeKok <aland@deployingradius.com> wrote:
| Manuel Guesdon wrote: | > On Fri, 25 Nov 2011 15:54:40 +0100 | > Alan DeKok <aland@deployingradius.com> wrote: | >> | Manuel Guesdon wrote: | >> | > Did you found some time to take a look to the module ? | >> | | >> | No, sorry. Maybe later... | > | > Is it possible plan integration in next Freeradius release ? | | You're responding to a message from a year ago. You're including | little or no useful information in the message. |
Sorry, I was thinking you'll see it in the thread :-( I was talking about this: << I've adapted rlm_sql to REDIS (http://redis.io/) key-store database. It handle authorize, accounting, checksimul and post-auth (only authorize is deeply tested). Authorize works like rlm_sql with groups, etc... Files are here: http://free.oxymium.net/freeradius/rlm_redisn/ Available as .tgz here: http://free.oxymium.net/freeradius/rlm_redisn-20111112-001.tgz
| If you had bothered to look, version 2.2.0 has a redis module. If | that doesn't answer your question, I have no idea what you want.
I've checked on github before before posting but it's not included and it's the same as rlm_redis. It's a complete auth, accounting,etc module. I'll follow Arran advice and post it in GitHub. Manuel -- ______________________________________________________________________ Manuel Guesdon - OXYMIUM
participants (4)
-
Alan DeKok -
Arran Cudbard-Bell -
Gabriel Blanchard -
Manuel Guesdon