[trivial PATCH 01/22] [libradius.h] eliminate build warnings
hi, this is a series of trivial patch for eliminating build warnings. this series doesn't solve warning "discards qualifiers from XXX type" , caused by assignments between CONST and non-CONST, such operation is deprecated by C99. if this make noises, plz forgive me. thanks! Tinggong Signed-off-by: Wang Tinggong <wangtinggong@gmail.com> --- src/include/libradius.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/include/libradius.h b/src/include/libradius.h index 9553544..9ea525a 100644 --- a/src/include/libradius.h +++ b/src/include/libradius.h @@ -225,7 +225,7 @@ typedef struct radius_packet { /* * Printing functions. */ -int fr_utf8_char(const uint8_t *str); +unsigned int fr_utf8_char(const uint8_t *str); void fr_print_string(const char *in, size_t inlen, char *out, size_t outlen); int vp_prints_value(char *out, size_t outlen, -- 1.6.0.6 =================================================== 北京福富软件技术股份有限公司福州分公司 增值业务部产品开发部 王廷功 TEL:0591-88389025 FAX:0591-83519928 ADDR:福州市铜盘路软件大道89号A区12#楼 ZIP:350003 Email: wangtg@ffcs.cn ===================================================
Wang Tinggong wrote:
hi, this is a series of trivial patch for eliminating build warnings.
Here's my review: Patches 01, (and related) 19, 20 - Don't put changes to a function prototype in a *separate* patch from changes to the source file. This breaks the build. Patches 11, 12, 13, 14, 15, 16 - OTP code. I'll let Frank review them. Patches 05, 06, 07, 08, 10, - adding function prototypes to remove warnings is good. But they belong in a header file, not in a C file. Many of the rest are minor, and have no impact other than messages when building. i.e. these are low priority items. Alan DeKok.
participants (2)
-
Alan DeKok -
Wang Tinggong