possible bug in rlm_krb5.c?
One of our engineers, Nalin, did a quick review of diffs between 3.0.0 and 3.0.1 and noticed this. I agree with Nalin, it looks like an unintentional mistake, was it?
I did a quick(ish?) skim of a diff between the two ...
Also from skimming that diff, I can randomly offer that in rlm_krb5.c, the switch statement that follows a call to krb5_verify_user_opt() falls through after the KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN case, but the similarly-structured switch statement after the krb5_get_init_creds_password() call includes a "break;". The omission in the first doesn't look intentional to me.
-- John
On 30 Jan 2014, at 15:00, John Dennis <jdennis@redhat.com> wrote:
KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN
Hm, yes. Now sure how that got removed. Put it back. I'm very surprised Coverity didn't spot that. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On 30 Jan 2014, at 15:53, Arran Cudbard-Bell <a.cudbardb@freeradius.org> wrote:
On 30 Jan 2014, at 15:00, John Dennis <jdennis@redhat.com> wrote:
KRB5KDC_ERR_C_PRINCIPAL_UNKNOWN
Hm, yes.
Now sure how that got removed.
Put it back. I'm very surprised Coverity didn't spot that.
Ah. The test build probably runs with MIT kerberos *sigh*. I think we need to build another test VM running FreeBSD or something, and do Coverity submissions from there too. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
participants (2)
-
Arran Cudbard-Bell -
John Dennis