Commit report for master branch
New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== No results mean we didn't succeed. Versus returning "empty string", which makes alternation fail. Fixes #460 Alan T. DeKok@2013-10-29T22:13:43Z Files modified: * src/modules/rlm_sql/rlm_sql.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/3d3e919350a64675b85d5... ====== Missed PAD macro Arran Cudbard-Bell@2013-10-29T18:10:15Z Files modified: * src/include/libradius.h Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/9386dd29d72a84baf7bef... ====== Proper fix for calculating encoded session-key length Conflicts: src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c Arran Cudbard-Bell@2013-10-29T17:55:05Z Files modified: * src/include/libradius.h * src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/94698a3345701ba588899... ====== Typo Alan T. DeKok@2013-10-29T13:22:10Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/e111294295ad91093ec9d... ====== Print the start of a Foreach block, too Alan T. DeKok@2013-10-29T13:17:10Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/32f4b311a2bd170bb82be... ====== Copy only one VP Alan T. DeKok@2013-10-29T13:17:09Z Files modified: * src/main/modcall.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/943e66b83f44e57bae368... ====== Increase size of LEAP session key buffer Alan T. DeKok@2013-10-29T12:37:30Z Files modified: * src/modules/rlm_eap/types/rlm_eap_leap/eap_leap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c0d9366a6edc9bd4084df... ====== Fix typo Arran Cudbard-Bell@2013-10-29T09:59:48Z Files modified: * src/modules/rlm_ldap/ldap.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/efb85c79bad462fb21075... ====== -- This commit summary was generated @2013-10-30T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).
On 10/29/2013 11:00 PM, The git bot wrote:
New activity for FreeRADIUS (the high performance and highly configurable RADIUS server)
====== No results mean we didn't succeed.
Versus returning "empty string", which makes alternation fail.
Fixes #460
What will happen for queries which are *supposed* to return nothing in the normal case e.g. %{sql:SELECT isbanned from bans where username='%{User-Name}'}
Phil Mayers wrote:
What will happen for queries which are *supposed* to return nothing in the normal case e.g.
%{sql:SELECT isbanned from bans where username='%{User-Name}'}
They still return nothing. The behavior is this: - queries which return empty strings are valid. - queries which fail are treated as empty strings when expanded because there's no "if/then/else" in %{...} - EXCEPT for %{%{foo}:-bar}. The failure of the first query means that the second one is used. The bug in rlm_sql was that SELECT returning no values was treated as an empty string, not as a failed query. So in an alternation, the empty string is a valid string, and the second part wasn't used. The use-case is selecting an IP address from a table: %{sql:SELECT ....} That should get you the IP, or *nothing* if the IP isn't in a table. Now let's say you want to return "255.255.255.255" if the IP isn't in the table. You do this: %{%{sql:SELECT ...}:-255.255.255.255} Previously, if there was no IP, you'd get '' as a result of the expansion. That's wrong. You now get '255.255.255.255', which is correct. Now, if you're dumb enough to put an empty string into the SQL table, you'll still get '' as the answer. But we can't help you there. The conditions in "if" statements behave the same, even after this change. if ("%{sql:SELECT ...}") { evaluates to '' if no results are returned. Because you haven't used alternation to say "if SELECT fails, give me another string". Alan DeKok.
participants (3)
-
Alan DeKok -
announceļ¼ freeradius.org -
Phil Mayers