[4.0.x] xlat function names can no longer contain dots ?
Hello FreeRADIUS team, I've been using xlat functions with dots in their names, e.g. "my.function". It worked fine until recently (well, that was more than a month ago), but not anymore with current master HEAD. The code that prevents it from working now is the following (in xlat_tokenize_function): https://github.com/FreeRADIUS/freeradius-server/blob/master/src/lib/unlang/x... /* * Special characters, spaces, etc. cannot be * module names. */ if (*q < '0') return 0; I think this might be unintended. Could you look into this ? Thanks! Regards, Nicolas. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
On Apr 6, 2020, at 12:18 PM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel@lists.freeradius.org> wrote:
I've been using xlat functions with dots in their names, e.g. "my.function". It worked fine until recently (well, that was more than a month ago), but not anymore with current master HEAD.
The code that prevents it from working now is the following (in xlat_tokenize_function):
https://github.com/FreeRADIUS/freeradius-server/blob/master/src/lib/unlang/x...
/* * Special characters, spaces, etc. cannot be * module names. */ if (*q < '0') return 0;
I think this might be unintended. Could you look into this ?
Dots and dashes should be allowed. I'll push a fix. Alan DeKok.
It works again. :) Thanks Alan! On Apr 6, 2020, at 12:18 PM, Chaigneau, Nicolas via Freeradius-Devel <freeradius-devel@lists.freeradius.org> wrote:
I've been using xlat functions with dots in their names, e.g. "my.function". It worked fine until recently (well, that was more than a month ago), but not anymore with current master HEAD.
The code that prevents it from working now is the following (in xlat_tokenize_function):
https://github.com/FreeRADIUS/freeradius-server/blob/master/src/lib/unlang/x...
/* * Special characters, spaces, etc. cannot be * module names. */ if (*q < '0') return 0;
I think this might be unintended. Could you look into this ?
Dots and dashes should be allowed. I'll push a fix. Alan DeKok. This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
participants (2)
-
Alan DeKok -
Chaigneau, Nicolas