Commit report for master branch
New activity for FreeRADIUS (the high performance and highly configurable RADIUS server) ====== Add license Alan T. DeKok@2015-03-01T16:04:09Z Files modified: * src/modules/proto_vmps/vqpcli.pl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/52b517d413e5f8124ef8a... ====== Taken from vmpsd on sourceforge, under the GPLv2 Alan T. DeKok@2015-03-01T16:04:08Z Files modified: * src/modules/proto_vmps/vqpcli.pl Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/0c0b60c0fee37533a5d56... ====== Encode / decode ethernet data types Alan T. DeKok@2015-03-01T15:59:36Z Files modified: * src/modules/proto_vmps/vqp.c Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c96776ddfb2baf57a5093... ====== -- This commit summary was generated @2015-03-02T00:00:02Z by lgfeed version 0.00 (https://github.com/arr2036/lgfeed).
On 02-03-15 00:00, The git bot wrote:
Encode / decode ethernet data types
Alan T. DeKok@2015-03-01T15:59:36Z Files modified: * src/modules/proto_vmps/vqp.c
Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c96776ddfb2baf57a5093...
I admit I've got no idea what vmps is, but the 4 in the memcpy feels wrong + case PW_TYPE_ETHERNET: + if (length != 6) goto unknown; + + memcpy(&vp->vp_ether, ptr, 4); + vp->vp_length = 6; + break; Especially when combined with this snippet later on + case PW_TYPE_ETHERNET: + memcpy(ptr, vp->vp_ether, vp->vp_length); -- Herwin Weststrate
That's a typo. I'll fix it.
On Mar 2, 2015, at 2:56 AM, Herwin Weststrate <herwin@quarantainenet.nl> wrote:
On 02-03-15 00:00, The git bot wrote: Encode / decode ethernet data types
Alan T. DeKok@2015-03-01T15:59:36Z Files modified: * src/modules/proto_vmps/vqp.c
Commit diff: https://github.com/FreeRADIUS/freeradius-server/commit/c96776ddfb2baf57a5093...
I admit I've got no idea what vmps is, but the 4 in the memcpy feels wrong
+ case PW_TYPE_ETHERNET: + if (length != 6) goto unknown; + + memcpy(&vp->vp_ether, ptr, 4); + vp->vp_length = 6; + break;
Especially when combined with this snippet later on
+ case PW_TYPE_ETHERNET: + memcpy(ptr, vp->vp_ether, vp->vp_length);
-- Herwin Weststrate
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
participants (3)
-
Alan DeKok -
announceļ¼ freeradius.org -
Herwin Weststrate