tempfile bug in dialupadmin script
Hi all, We got a bug report in Debian about an unsafe use of a hard coded tempfile in one of the dialupadmin scripts, so I thought I'd pass on our fix. http://git.debian.org/?p=collab-maint/freeradius.git;a=commitdiff;h=e741df7c... Cheers, -- -------------------------------------------------------------------------- | Stephen Gran | Death, when unnecessary, is a tragic | | steve@lobefin.net | thing. -- Flint, "Requiem for | | http://www.lobefin.net/~steve | Methuselah", stardate 5843.7 | --------------------------------------------------------------------------
Stephen Gran wrote:
We got a bug report in Debian about an unsafe use of a hard coded tempfile in one of the dialupadmin scripts, so I thought I'd pass on our fix.
OK. Any chance I can get you to switch to using the new freeradius git tree? That would let me pull patches in from your tree much more easily. Or send me an SSH key via private email, and I'll add you to the freeradius committers. Alan DeKok.
On Tue, Aug 26, 2008 at 02:56:38PM +0200, Alan DeKok said:
Stephen Gran wrote:
We got a bug report in Debian about an unsafe use of a hard coded tempfile in one of the dialupadmin scripts, so I thought I'd pass on our fix.
OK. Any chance I can get you to switch to using the new freeradius git tree? That would let me pull patches in from your tree much more easily.
We plan to rebase in the near future - up to now we've been doing a cvs<->git sync, which was a bit painful and I'm very glad that you've moved to git :)
Or send me an SSH key via private email, and I'll add you to the freeradius committers.
I'm not sure that I manage to come up with enough good patches to warrant that yet :) If it looks like I am likely to be supplying a bunch of patches, I'll bug you about it then. For now, I can send git format-patch style patches to the list that you can import with git-am if that's more helpful. I'll attach this patch that way. -- -------------------------------------------------------------------------- | Stephen Gran | BOFH excuse #333: A plumber is needed, | | steve@lobefin.net | the network drain is clogged | | http://www.lobefin.net/~steve | | --------------------------------------------------------------------------
Stephen Gran wrote:
We plan to rebase in the near future - up to now we've been doing a cvs<->git sync, which was a bit painful and I'm very glad that you've moved to git :)
It works. It's worse than mercurial in many ways, but ends up being more useful.
I'm not sure that I manage to come up with enough good patches to warrant that yet :) If it looks like I am likely to be supplying a bunch of patches, I'll bug you about it then. For now, I can send git format-patch style patches to the list that you can import with git-am if that's more helpful. I'll attach this patch that way.
Applied && pushed. Alan DeKok.
participants (2)
-
Alan DeKok -
Stephen Gran