Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all. If noone has anything against the patch I would like to go ahead and apply it to cvs head and 1.1.3pre Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all.
If noone has anything against the patch I would like to go ahead and apply it to cvs head and 1.1.3pre
I for one would be more comfortable if your mail didn't have a bogus signature. Stefan -- Stefan WINTER Stiftung RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche Ingenieur Forschung & Entwicklung 6, rue Richard Coudenhove-Kalergi L-1359 Luxembourg E-Mail: stefan.winter@restena.lu Tel.: +352 424409-1 http://www.restena.lu Fax: +352 422473
On Wed 16 Aug 2006 12:37, Stefan Winter wrote:
Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all.
If noone has anything against the patch I would like to go ahead and apply it to cvs head and 1.1.3pre
I for one would be more comfortable if your mail didn't have a bogus signature.
So would I. It also doesn't verify on my mailer. I wonder what went wrong? -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wed 16 Aug 2006 12:37, Stefan Winter wrote:
Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all.
If noone has anything against the patch I would like to go ahead and apply it to cvs head and 1.1.3pre
I for one would be more comfortable if your mail didn't have a bogus signature.
Sent again. This time with inline signing. Hopefully it will survive the list. - -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFE4vQ1AcdsUt9pJjwRAnySAJ9CCCFQfxXwQT9J90SWmNzI12OxUgCffNTm tVxeIH/jm9lJe8RBWVNBe0g= =oCtZ -----END PGP SIGNATURE-----
Peter Nixon wrote:
Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all.
I think it should be an option (disabled by default) so it doesn't break custom scripts monitoring the logs. Ideally, the whole string could be user-defined, with a default value corresponding to the actual behaviour. Something like: # This string is appended to each line of authentication logging. log_auth_append = "from client %{Client-IP-Address} port %{NAS-Port}" -- Nicolas Baradakis
On Wed 16 Aug 2006 13:05, Nicolas Baradakis wrote:
Peter Nixon wrote:
Does anyone have anything against the attached patch? We are using it in production to also output the DID (CalledStationID) to radiusd.log alongside the CID. If there is no DID it shouldn't change the logging format at all.
I think it should be an option (disabled by default) so it doesn't break custom scripts monitoring the logs.
Ideally, the whole string could be user-defined, with a default value corresponding to the actual behaviour. Something like:
# This string is appended to each line of authentication logging. log_auth_append = "from client %{Client-IP-Address} port %{NAS-Port}"
Yep. That would definitely be a nicer way to do logging :-) -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
participants (3)
-
Nicolas Baradakis -
Peter Nixon -
Stefan Winter