todays (13.04.06) cvs entry doesn't compile
hi developers, todays (13.04.06) cvs entry (just checked out) does not compile due to a change commited yesterday, this is valid for building by make (from scratch), dpkg-buildpackage (debian) and rpmbuild (at least suse oss10 and sles9). the problem is the "commenting out" of line 24 in "radiusd/src/lib/Makefile": CFLAGS += -DHMAC_SHA1_DATA_PROBLEMS putting it in yesterdays state (like the line above) fixes it of course, but as the veriable "sha1_data_problems" ist used in several places (hmacsha1.c, eapsimlib.c, radeapclient.c, hmacsha1.c:) i doubt that this is really an intended solution ... regards markus -- Markus Krause email: krause@biochem.mpg.de Computing Center Tel.: 089 - 89 40 85 99 Group Lottspeich / Proteomics Fax.: 089 - 89 40 85 98 --------------------------------------------------------------------- This message was sent using https://webmail.biochem.mpg.de If you encounter any problems please report to rz-linux@biochem.mpg.de
Markus Krause <krause@biochem.mpg.de> wrote:
putting it in yesterdays state (like the line above) fixes it of course, but as the veriable "sha1_data_problems" ist used in several places (hmacsha1.c, eapsimlib.c, radeapclient.c, hmacsha1.c:) i doubt that this is really an intended solution ...
I'll go fix that. That code is wrong on so many levels. Debugging of protocols & hash functions should be done by compile-time changes, not by run-time changes. Alan DeKok.
participants (2)
-
Alan DeKok -
Markus Krause