Is there any chance to get updated python module upstream?
Hi, Alan & list subscribers! Is there any chance to get updated python module (the one I'd posted here couple of times in the past, or the one in bugzilla) into freeradius mainline? The situation haven't changed much from the past. The only users of python module I know use patched version, either mine or another. Other folks try to use "stock" module, but it is failing horribly and people get disappointed by this. I will resend my last snapshot here at this weekend. -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head
Paul P Komkoff Jr wrote:
Is there any chance to get updated python module (the one I'd posted here couple of times in the past, or the one in bugzilla) into freeradius mainline?
Yeah, it should probably go in.
The situation haven't changed much from the past. The only users of python module I know use patched version, either mine or another. Other folks try to use "stock" module, but it is failing horribly and people get disappointed by this.
Thanks. Alan DeKok. -- http://deployingradius.com - The web site of the book http://deployingradius.com/blog/ - The blog
On Fri 02 Mar 2007 10:39, Paul P Komkoff Jr wrote:
Hi, Alan & list subscribers!
Is there any chance to get updated python module (the one I'd posted here couple of times in the past, or the one in bugzilla) into freeradius mainline?
The situation haven't changed much from the past. The only users of python module I know use patched version, either mine or another. Other folks try to use "stock" module, but it is failing horribly and people get disappointed by this.
I will resend my last snapshot here at this weekend.
I have started doing some tests with the python module. Please send me your patches. If they work, I would be happy to commit them to cvs... Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
Replying to Peter Nixon:
I have started doing some tests with the python module. Please send me your patches. If they work, I would be happy to commit them to cvs...
I am sitting for more than a year in production with this patch applied. Basically, it's a complete rewrite, using latest python C api docs. -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head
Paul P Komkoff Jr wrote:
Replying to Peter Nixon:
I have started doing some tests with the python module. Please send me your patches. If they work, I would be happy to commit them to cvs...
I am sitting for more than a year in production with this patch applied.
Basically, it's a complete rewrite, using latest python C api docs.
The problem of a complete rewrite is that's difficult to know what has changed. I think the set of 10 patches posted last year is a lot better than one huge patch. It starts from here in the mailing list archive: http://lists.freeradius.org/pipermail/freeradius-devel/2006-January/009416.h... -- Nicolas Baradakis
Replying to Nicolas Baradakis:
Paul P Komkoff Jr wrote:
The problem of a complete rewrite is that's difficult to know what has changed. I think the set of 10 patches posted last year is a lot better than one huge patch.
I agree with you to the extent that it's better if you are going to review the changes to see if they are not overly intrusive and break good code. In this case, however, the whole rlm_python is well known broken, so as for me trying to track individual changes just doesn't make sense. However, I've tried to split up the changes last year, yes. You can see what I've did there if you like. -- Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key This message represents the official view of the voices in my head
On Sun 04 Mar 2007 18:47, Nicolas Baradakis wrote:
Paul P Komkoff Jr wrote:
Replying to Peter Nixon:
I have started doing some tests with the python module. Please send me your patches. If they work, I would be happy to commit them to cvs...
I am sitting for more than a year in production with this patch applied.
Basically, it's a complete rewrite, using latest python C api docs.
The problem of a complete rewrite is that's difficult to know what has changed. I think the set of 10 patches posted last year is a lot better than one huge patch.
Hi Nicolas Given that Paul also wrote the patchset you refer to I assume that the are: a) related b) that the one he just posted is better than the ones he posted over a year ago.. or at least the same... As far as I can tell one of the main reasons that the previous patch set got overlooked was because it didn't get submitted to the bug tracker and none of the devs were running rlm_python themselves.. I am now playing with rlm_python, and in absence of another dev doing so I will adopt this patch for testing and inclusion... Paul: is there any chance of you sending me this patch against 1.1.4 and cvs HEAD? (It would save me some time while testing it..) Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
Peter Nixon wrote:
As far as I can tell one of the main reasons that the previous patch set got overlooked was because it didn't get submitted to the bug tracker and none of the devs were running rlm_python themselves..
I am now playing with rlm_python, and in absence of another dev doing so I will adopt this patch for testing and inclusion...
Thanks for testing rlm_python. I'm bringing the split up version to your attention because it may be easier for you to review the changes before committing to the CVS. -- Nicolas Baradakis
On Fri 02 Mar 2007 22:04, Paul P Komkoff Jr wrote:
Replying to Peter Nixon:
I have started doing some tests with the python module. Please send me your patches. If they work, I would be happy to commit them to cvs...
I am sitting for more than a year in production with this patch applied.
Basically, it's a complete rewrite, using latest python C api docs.
I have committed it to the 1.1.x branch. (I will commit to cvs head when you send me an updated patch or when I get around to making the changes myself.. whichever comes first :-) Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
participants (4)
-
Alan DeKok -
Nicolas Baradakis -
Paul P Komkoff Jr -
Peter Nixon