[Bug 269] Many compiler warnings with gcc 4.0
Steven Simon
simon.s at apple.com
Wed Aug 31 22:19:31 CEST 2005
looks like you beat me to it ;)
Steve
On Aug 31, 2005, at 1:09 PM, Alan DeKok wrote:
> Frank Cusack <fcusack at fcusack.com> wrote:
>> Forcing unsigned char would be a mistake, IMHO. I personally
>> think casts
>> are good. One man's ugly notation is another man's inline
>> documentation.
>
> The casts hilight API incompatibilities, and potential security
> issues.
>
> Maybe since we're doing massive re-writes anyhow, we could have:
>
> VALUE_PAIR {
> union {
> char strvalue[];
> uint8_t octets[];
> ...
> } data;
> }
>
> And then use the "right" data member to access the data. "uint8_t"
> shouldn't be passed to "strcpy", especially if we're using "uint8_t"
> as "opaque data".
>
> Alan DeKok.
>
> -
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/
> devel.html
More information about the Freeradius-Devel
mailing list