IPv4 strvalue

Nicolas Baradakis nbk at sitadelle.com
Mon Dec 12 12:01:28 CET 2005


Alan DeKok wrote:

> Nicolas Baradakis <nbk at sitadelle.com> wrote:
> > It seems the following patch solves the problem for me, is it safe to
> > apply it to the CVS ? (I'm unsure if lvalue or strvalue is used like
> > this elsewhere)
> 
>   Not really.  The patch works, and is not a bad idea.
> 
>   However, generally it would be good to *not* do this.  It's a hack
> so that people can do regex matches on IP addresses.  I hacked the CVS
> head to fix this a while back, and that hasn't been back-ported to 1.1.x.
> 
>   I would say add this patch to 1.1.x, *and* fix src/lib/print.c, to
> print out the IP address.  Right now, it assumes that vp->strvalue is
> the printed form of the IP, which is not always right.

Many thanks for explaining all these things to me. I've updated the CVS
exactly as you said.

-- 
Nicolas Baradakis




More information about the Freeradius-Devel mailing list