Possible Bug in valuepair / rlm_file etc etc.

[Joe Maimon]

Alister Winfield wrote:

> 
> 
> Anyway just noticed another unfortunate feature in rlm_file.c. 

function?

Do you mean in src/main/valuepair.c paircmp() (cvs renamed to 
paircompare() )?

> The !=
> and !~ tests only notice if the very first matching attribute doesn't
> match the value / regex but there is no way of asking the question does
> this attribute value pair NOT exist anywhere in the packet. I have a fix
> for this which involves effectively doing a positive match then
> inverting the response if required. 

paircmp() loops every av.

Perphaps if you posted your fix simple schmoes like me can take a look.
It wont actually buy you anything if I do, but perhaps some others might 
be interested.

> 
> --
> Alister Winfield.
> 
> - 
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
> 
>